This repository has been archived by the owner on Nov 15, 2022. It is now read-only.
Improve status bar branch list UX #634
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbayley
force-pushed
the
status-bar-branch-list
branch
from
bb0167c
to
c37fd03
Compare
|
@akonwi I don't think the build failure has anything to do with the files in this PR… |
|
This is great. Do we really need both options of right clicking on the branch name and a modifier + click? Wouldn't one suffice? I vote for the right click because to me it feels better than having to touch the keyboard for what is already a mouse only interaction. |
danielbayley
force-pushed
the
status-bar-branch-list
branch
from
3da1aae
to
ac1ebf5
Compare
|
@akonwi I suppose we don't really need both, if you'd prefer not to… It's quicker to use with mod keys for me personally, since I already have one set up on there to launch an external git app. Anyway I altered it to ignore any mod keys so that it stays out of the way of other packages… |
Add `git-branch` to class list of the new branch modal, to distinguish it from other modals for styling purposes.
Allow other packages to utilise modifier keys when clicking on the current branch status bar indicator without interfering with this package.
Add ability to create new branch from the context menu.
danielbayley
force-pushed
the
status-bar-branch-list
branch
from
ac1ebf5
to
3d85f47
Compare
|
This has been merged |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.