This repository has been archived by the owner on Nov 15, 2022. It is now read-only.
Allowing GPG signing of Git tags #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! that looks great! Thanks, I really appreciate updating the tests. I'm sure this is something others will really appreciate too I just moved the config into its own section. I figure it's a small enough change to the existing behavior so it should be okay. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a huge change, but my first modification to an Atom package, so I would encourage a careful review. Added a config boolean (and a test to cover it). Defaults to previous behavior. Really just changes
tag -atotag -sif thesignTagsboolean istrue.Without this, I don't get the pretty "Verified" text next to my tags in GitHub.