Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

opend projects not all git repo,git-plus Invalid #663

Closed
wants to merge 1 commit into from
Closed

opend projects not all git repo,git-plus Invalid #663

wants to merge 1 commit into from

Conversation

yanfeng42
Copy link
Contributor

RepoA is a SVN repo; RepoB is a GIT repo. open RepoA,and then open RepoB. Now,git-plus will be Invalid on RepoB!

Have you looked at the guidelines for contributing to this codebase?
Have you added tests and run apm test?

RepoA is a SVN repo; RepoB is a GIT repo. open RepoA,and then open RepoB. Now,git-plus will be Invalid on RepoB!
@akonwi
Copy link
Owner

akonwi commented May 18, 2017

I can't reproduce the error. How are you opening Repo B? Are you adding it as a project folder or are you simply opening it in a new window?

@yanfeng42
Copy link
Contributor Author

yanfeng42 commented May 18, 2017

Like screenshots, the order is the key to reproduce the error.

2017-05-18 11 44 09

@akonwi
Copy link
Owner

akonwi commented May 18, 2017

What is the error you are seeing that implies the package doesn't recognize repoB?

@yanfeng42
Copy link
Contributor Author

git-plus version: 7.8.0

git.coffee [sm]:146 Uncaught (in promise) TypeError: Cannot read property 'getWorkingDirectory' of null
    at /Users/yanfeng/.atom/packages/git-plus/lib/git.coffee:146:43
    at Array.forEach (native)
    at /Users/yanfeng/.atom/packages/git-plus/lib/git.coffee:145:17

@akonwi
Copy link
Owner

akonwi commented May 18, 2017

Can you also give some exact steps to reproduce this? Which commands are you trying to run?

@yanfeng42
Copy link
Contributor Author

yanfeng42 commented May 18, 2017

See this GIF. My Atom Version is 1.14.0. Notice the Order!When RepoB,a git repo,is below RepoA, git-plus Invalid

a-b

@akonwi
Copy link
Owner

akonwi commented May 19, 2017

The latest version of atom is 1.17.0. What's preventing you from upgrading?

I'm unable to reproduce this so I'm wondering if upgrading might help you.

@yanfeng42
Copy link
Contributor Author

same error,with Atom 1.17.0 git-plus 7.8.1

/Users/yanfeng/.atom/packages/git-plus-7.8.1/lib/git.coffee:279 Uncaught (in promise) TypeError: Cannot read property 'getWorkingDirectory' of null
    at /Users/yanfeng/.atom/packages/git-plus/lib/git.coffee:146:43
    at Array.forEach (native)
    at /Users/yanfeng/.atom/packages/git-plus/lib/git.coffee:145:17
/Users/yanfeng/.atom/packages/git-plus-7.8.1/lib/git.coffee:279 Uncaught (in promise) TypeError: Cannot read property 'getWorkingDirectory' of null
    at /Users/yanfeng/.atom/packages/git-plus/lib/git.coffee:146:43
    at Array.forEach (native)
    at /Users/yanfeng/.atom/packages/git-plus/lib/git.coffee:145:17

2017-05-19 09 58 35

@akonwi
Copy link
Owner

akonwi commented May 19, 2017

Alright I just pushed 7.9.1 with the change

@akonwi akonwi closed this May 19, 2017
akonwi added a commit that referenced this pull request May 22, 2017
This fixes a mistake made in attempting to fix #663
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants