This repository has been archived by the owner on Nov 15, 2022. It is now read-only.
Amend complex commits #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could not write it as a unit test because of the parse functions being private
|
Sweet! I'll try to publish this change later today |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving the bug from issue #681 and #710
Sadly I didn't found any way to create a complete test for this function
I added a full test of the Commit Amend with a complex commit message, but I can see how some changes in the future might break the function without breaking the tests
Actually the original code have exactly the same problem, the tests cannot validate the return of the 'parse' function because it's private to the 'git-commit-amend' file
So if some future changes breaks the return to another valid return, but not the correct one (maybe missing one of the previous modifications), the tests will still pass