Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversions where the job fails because of no disk space get registered as having succeeded #49

Closed
NathanSkene opened this issue Sep 17, 2020 · 0 comments · Fixed by #52
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@NathanSkene
Copy link

Hey Akos,

Very minor bug here but thought I should flag it anyway.

Ran out of disk space while doing the conversion.

Failed to convert note: # Golgi
 Error: ENOSPC: no space left on device, open '/Users/natske/Applications/yarle/./out/simpleNotes/My Notes2/201107121226 golgi.md'
    at Object.openSync (fs.js:462:3)
    at Object.writeFileSync (fs.js:1362:35)
    at Object.exports.writeMdFile (/Users/natske/Applications/yarle/dist/utils/file-utils.js:7:12)
    at Object.exports.processNode (/Users/natske/Applications/yarle/dist/process-node.js:30:22)
    at EventEmitter.<anonymous> (/Users/natske/Applications/yarle/dist/yarle.js:31:28)
    at EventEmitter.emit (events.js:315:20)
    at SAXStream.<anonymous> (/Users/natske/Applications/yarle/node_modules/xml-flow/lib/xml-flow.js:142:15)
    at SAXStream.emit (events.js:315:20)
    at SAXParser.me._parser.<computed> [as onclosetag] (/Users/natske/Applications/yarle/node_modules/sax/lib/sax.js:258:17)
    at emit (/Users/natske/Applications/yarle/node_modules/sax/lib/sax.js:624:35) {
  errno: -28,
  syscall: 'open',
  code: 'ENOSPC',
  path: '/Users/natske/Applications/yarle/./out/simpleNotes/My Notes2/201107121226 golgi.md'
}
Note # Golgi
 converted successfully.
Notes processed: 3618
Conversion finished: 3618 succeeded, 0 failed

Note that in the final statement it says that '0 failed' even though many hundreds didn't write because there was no disk space available.

@akosbalasko akosbalasko added bug Something isn't working good first issue Good for newcomers labels Sep 17, 2020
@rodbv rodbv mentioned this issue Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants