Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dateutil.parser.parse throws ValueError on crud date strings #17

Closed
ranchodeluxe opened this issue Feb 24, 2016 · 2 comments
Closed

dateutil.parser.parse throws ValueError on crud date strings #17

ranchodeluxe opened this issue Feb 24, 2016 · 2 comments
Assignees
Labels

Comments

@ranchodeluxe
Copy link
Collaborator

Issue #14 highlights we need to wrap dateutil.parser.parse:

>>> from dateutil import parser
>>> parser.parse('to blah')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/src/datefinder/venv/lib/python3.4/site-packages/python_dateutil-2.4.2-py3.4.egg/dateutil/parser.py", line 1008, in parse
  File "/usr/local/src/datefinder/venv/lib/python3.4/site-packages/python_dateutil-2.4.2-py3.4.egg/dateutil/parser.py", line 395, in parse
ValueError: Unknown string format

Fixed and added a passing test in this draft implementation

@akoumjian
Copy link
Owner

Theoretically we shouldn't be passing dateutil bad datetime strings. Not sure if this issue is ready to close or not.

@ranchodeluxe
Copy link
Collaborator Author

@akoumjian: yep, that was in the PR #19 thanks! We agreed to let it bubble

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants