Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve strict=True #109

Merged
merged 3 commits into from Jul 31, 2022
Merged

Improve strict=True #109

merged 3 commits into from Jul 31, 2022

Conversation

ecatkins
Copy link
Contributor

@ecatkins ecatkins commented Jul 15, 2019

I am finding that a number of correct date formats are failing to parsed by strict=True. I have made changed to to patch this in extract_date_strings_inner and I have also added a new test file to account for these, I don't think find_dates is being tested in strict mode under the current suite?

  1. mm/dd/yyyy e.g. 09/06/2018
  2. xxth day of yyyy e.g. 19th day of May, 2015 (NB: Had to change a spuriously passed test intest_extract_date_strings.py

@hmoravec
Copy link

@akoumjian This PR should fix the strict mode and it's been opened for more than a year. Would it be possible to merge it?

@akoumjian
Copy link
Owner

Only took me three years, but thank you!

@akoumjian akoumjian merged commit f2ab941 into akoumjian:master Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants