Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax phoenix_html to make it compatible with phoenix v1.7.0-rc.2 #13

Merged
merged 2 commits into from
Feb 11, 2023

Conversation

paridin
Copy link
Contributor

@paridin paridin commented Feb 11, 2023

I recently add the mjml_eex to a new fresh project by default that uses the phoenix v1.7.0-rc.2.

Causing the following error.

Resolution completed in 0.089s
Because "the lock" specifies phoenix_html 3.3.0 and mjml_eex >= 0.2.0 depends on phoenix_html ~> 3.2.0, the lock is incompatible with mjml_eex >= 0.2.0.
And because your app depends on the lock, mjml_eex >= 0.2.0 is forbidden.
So, because your app depends on mjml_eex ~> 0.9.0, version solving failed.
** (Mix) Hex dependency resolution failed

I just drop the patch from phoenix_html to keep compatibility.

On the other hand, I take the dare to update the dependencies to the latest version available.

The lock now points to phoenix_html "3.3.0"

@coveralls
Copy link

coveralls commented Feb 11, 2023

Pull Request Test Coverage Report for Build 17426209695593ee442a9067e1bbb50916f1f080-PR-13

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.85%

Totals Coverage Status
Change from base Build dc780c4652041cd0d094a9e4ef5769e342f6572f: 0.0%
Covered Lines: 123
Relevant Lines: 127

💛 - Coveralls

@akoutmos akoutmos merged commit 376df98 into akoutmos:master Feb 11, 2023
@akoutmos
Copy link
Owner

Thanks for the contribution!! I'll cut a release over the weekend with these changes :).

@paridin paridin deleted the relax-deps branch February 11, 2023 02:43
@akoutmos
Copy link
Owner

Just cut the release. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants