add 4 new predicates #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoutmos
reviewed
Apr 16, 2020
| defmodule Unplug.Predicates.AppConfigIn do | ||
| @moduledoc """ | ||
| Given an application and a key, execute the plug if the configured value | ||
| matches the expected value. |
There was a problem hiding this comment.
For the In style predicates, I would just update the moduledoc to make it clear that the configured value is in an enumerable of values. Something like if the value is in the the provided list of values.
akoutmos
reviewed
Apr 16, 2020
andersonmcook
approved these changes
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EnvVarInEnvVarNotInAppConfigInAppConfigNotIn