Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trailing space on UGC line causes product expiration to fail #652

Closed
3 tasks done
akrherz opened this issue Sep 10, 2022 · 2 comments
Closed
3 tasks done

Trailing space on UGC line causes product expiration to fail #652

akrherz opened this issue Sep 10, 2022 · 2 comments
Assignees
@akrherz
Labels
bug

Comments

@akrherz
Copy link
Owner

akrherz commented Sep 10, 2022 •
edited

This AWW from TFX has a subtle failure

WWUS85 KTFX 092134
AWWBZN
MTZ055-092245-

There's a trailing space.

  • account for this
  • ensure text_products table insertion does not have a null expiration (pyWWA issue)
  • generate a warning in this case (pyWWA issue)
@akrherz akrherz added the bug label Sep 10, 2022
@akrherz akrherz self-assigned this Sep 10, 2022
akrherz added a commit that referenced this issue Sep 10, 2022
@akrherz
allow trailing whitespace on UGC line #652
c3fb566
akrherz added a commit to akrherz/pyWWA that referenced this issue Sep 10, 2022
@akrherz
ensure no null expiration for text_products
9866f99 
refs akrherz/pyIEM#652
@akrherz akrherz mentioned this issue Sep 10, 2022
Merged
akrherz added a commit that referenced this issue Sep 10, 2022
@akrherz
Merge pull request #653 from akrherz/gh652_trailing_space
090fdce 
allow trailing whitespace on UGC line #652
@akrherz
Copy link
Owner Author

akrherz commented Sep 10, 2022

archive of products fixed as well.

@akrherz akrherz closed this as completed Sep 10, 2022
@akrherz
Copy link
Owner Author

akrherz commented Sep 11, 2022

NB, I contacted the NWS regarding this and they have additionally corrected the TFX office template to fix this going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akrherz akrherz

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akrherz