Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented dropdownToggle in dart #20

Merged
merged 4 commits into from
Jan 15, 2014
Merged

Implemented dropdownToggle in dart #20

merged 4 commits into from
Jan 15, 2014

Conversation

poolik
Copy link
Collaborator

@poolik poolik commented Jan 14, 2014

Some time ago I implemented it for my own pet project and now discovering your attempt to port the whole angular.ui package to dart I wanted to contribute.

As you can see I also added 2 files _specs.dart and jasmine_syntax.dart. I found them from angular.dart-s team own repository and I think it makes porting a lot easier, because fewer modifications are required to port tests (the syntax is basically the same).

Hope you accept and maybe we can collaborate on porting other directives as well.

akserg added a commit that referenced this pull request Jan 15, 2014
Implemented dropdownToggle in dart
@akserg akserg merged commit b3753d3 into akserg:master Jan 15, 2014
@akserg
Copy link
Owner

akserg commented Jan 15, 2014

Hi Tõnis,

Really appreciated you input. Very valuable. Other ideas, thoughts? :)

@poolik
Copy link
Collaborator Author

poolik commented Jan 15, 2014

I could implement tooltip and progressbar as well, as I'd need them in my project anyways

@akserg
Copy link
Owner

akserg commented Jan 15, 2014

Sure.

On 15 January 2014 14:41, Tõnis Pool notifications@github.com wrote:

I could implement tooltip and progressbar as well, as I'd need them in my
project anyways


Reply to this email directly or view it on GitHubhttps://github.com//pull/20#issuecomment-32358020
.

@akserg
Copy link
Owner

akserg commented Jan 19, 2014

Hi,
I have implemented 'Timeout', so you might need it for your components.

Sergey.

On 15 January 2014 15:40, Sergey Akopkokhyants akserg@gmail.com wrote:

Sure.

On 15 January 2014 14:41, Tõnis Pool notifications@github.com wrote:

I could implement tooltip and progressbar as well, as I'd need them in my
project anyways


Reply to this email directly or view it on GitHubhttps://github.com//pull/20#issuecomment-32358020
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants