Skip to content
This repository

Fixed widget iterator going out of range with ui.Tree #87

Merged
merged 1 commit into from about 1 year ago

2 participants

Nican Sergey Akopkokhyants
Nican
Nican commented

Hey!

I would like to thank you for porting over the awesomeness of GWT to Dart, I was really can not get used to how limited WebUI is.

One question that I have is, did you really have to port the exact event system from GWT? One thing that I hated about GWT is the fact you had 3 different classes for every event; Would it not just be easier to use Dart's Stream feature?

Sergey Akopkokhyants akserg merged commit a387e0f into from
Sergey Akopkokhyants akserg closed this
Sergey Akopkokhyants
Owner
akserg commented
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

May 06, 2013
Nican Nican Fixed widget iterator going out of range with ui.Tree ac56b60
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 1 addition and 1 deletion. Show diff stats Hide diff stats

  1. +1 1  lib/src/ui/widget_iterators.dart
2  lib/src/ui/widget_iterators.dart
@@ -56,7 +56,7 @@ class _WidgetsIterator<Widget> implements Iterator<Widget> {
56 56 }
57 57
58 58 bool _hasNext() {
59   - return (index < _contained.length);
  59 + return (index < (_contained.length-1));
60 60 }
61 61
62 62 Widget _next() {

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.