fix(glow-capture): check parent template ref when unmounting #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, I want to thank you for this really cool plugin, keep the good work ❤️ ! However, I found a little problem using it.
👽 The problem
The plugin works pretty good but it faces an issue when you unmount the
<GlowCapture>
component. It happened when one of my component using aGlowCapture
was unmounted. In my case, my component is rendered with av-if
. I had the following error when thev-if
condition of my component is set tofalse
:It happens in the
GlowCapture
component, in theonUnmount
hook :💎 The solution
I just added an early return if the
elementParent.value
isundefined
ornull
. That way, it prevents the error.I hope you find this fix useful. Let me know if something must be changed in my PR.