Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a perfectly working calendar app in apps section Closes#18 #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

khushi0704
Copy link
Contributor

@khushi0704 khushi0704 commented Dec 7, 2020

Issue : add a calendar app
status : solved this issue , I have added a feature of Calendar app in the apps sections of MarvellOS .
Upon Clicking on the calendar button , the user has to type the year whose calendar he/she wants to look at and then simple he'll be directed to the next window which displays calendar for the particular year the user has input.
for user flexibility , I have added home button in each window of calendar screens so it makes it easier for the user to switch back to the apps section easily . Here is a sample view :

Screenshot (61)

Screenshot (63)

Screenshot (60)

Copy link
Owner

@akshgpt7 akshgpt7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good, just that the idea behind the app is a bit different: Instead of the user entering an year to go to, the app will show the current month's calendar, and will have Forward and Back buttons to move months. You should also make a dropdown to select an year, that'll take you to January of that month.
(So, at a time, the screen will just have one month's calendar)

MarvellOS.py Outdated Show resolved Hide resolved
MarvellOS.py Show resolved Hide resolved
@akshgpt7
Copy link
Owner

akshgpt7 commented Dec 7, 2020

Also, can you add one of these keywords to your PR description, and link the relevant issue.
(This will close the issue automatically once this PR is merged)

@khushi0704
Copy link
Contributor Author

Also, can you add one of these keywords to your PR description, and link the relevant issue.
(This will close the issue automatically once this PR is merged)

@khushi0704 khushi0704 closed this Dec 7, 2020
@khushi0704
Copy link
Contributor Author

Also, can you add one of these keywords to your PR description, and link the relevant issue.
(This will close the issue automatically once this PR is merged)

@khushi0704 khushi0704 reopened this Dec 7, 2020
@khushi0704
Copy link
Contributor Author

Also, can you add one of these keywords to your PR description, and link the relevant issue.
(This will close the issue automatically once this PR is merged)

so you want me to work on this and then merge again?

@khushi0704
Copy link
Contributor Author

as for now , I would request you to merge this pull request . we can open an issue for enchancing the calendar window

@khushi0704
Copy link
Contributor Author

This looks really good, just that the idea behind the app is a bit different: Instead of the user entering an year to go to, the app will show the current month's calendar, and will have Forward and Back buttons to move months. You should also make a dropdown to select an year, that'll take you to January of that month.
(So, at a time, the screen will just have one month's calendar)

okay then I'll do that and merge

@akshgpt7
Copy link
Owner

akshgpt7 commented Dec 9, 2020

@khushi0704 You need not do everything from scratch, just edit this PR itself.

@khushi0704 khushi0704 changed the title added a perfectly working calendar app in apps section added a perfectly working calendar app in apps section Closes#18 Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants