Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes made on Events page #1573

Merged
merged 2 commits into from
Jun 1, 2024

Conversation

Noopur-Thombare
Copy link
Contributor

@Noopur-Thombare Noopur-Thombare commented May 19, 2024

Related Issue

Closes: #1569

Description

I had added more spacing between the cards so that they are not overlapping with each other and also with the footer.
Also i had added hover effect which increase the size of Srila Prabhupada's image on hovering.

Checklist

  • My code adheres to the established style guidelines of the project.
  • I have included comments in areas that may be difficult to understand.
  • My changes have not introduced any new warnings.
  • I have conducted a self-review of my code.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Noopur-Thombare! 🎉 Thank you for submitting your pull request for Moksh. Our dedicated team will review it diligently.Your contribution is valuable and we appreciate your efforts to improve our project.

@akshitagupta15june
Copy link
Owner

Please add screenshots of changes

@Noopur-Thombare
Copy link
Contributor Author

I had merged 2 images one is normal and other one is after hovering effect

Screenshot 2024-05-23 092119

sufficient space is added between card and footer

Screenshot 2024-05-23 092306

cards are not overlapping after hovering

Screenshot 2024-05-23 092330

Mobile compatible
cards are not overlapping even in small size
Screenshot 2024-05-23 093145

@Noopur-Thombare
Copy link
Contributor Author

@akshitagupta15june i had made changes on Events page , please check

@akshitagupta15june akshitagupta15june merged commit c463ac1 into akshitagupta15june:main Jun 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Responsiveness should be added on ISKCON Events page
2 participants