Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the new version of the 'tabbar' does not work the 'tabBarPosition' property #2288

Closed
rogoja opened this issue Aug 25, 2017 · 11 comments
Closed
Labels

Comments

@rogoja
Copy link

rogoja commented Aug 25, 2017

Version

Tell us which versions you are using:

  • react-native-router-flux v4.0.0-beta.19
  • react-native v0.46.4

Expected behaviour

When specifying the " tabBarPosition='bottom' " property, the tabbar should be displayed at the bottom.

Actual behaviour

Is displayed at the top.

In the previous version it works correctly

@megamind2301
Copy link

+1

3 similar comments
@seratonik
Copy link

+1

@v-anton
Copy link

v-anton commented Aug 27, 2017

+1

@sachithamh
Copy link

+1

@aksonov
Copy link
Owner

aksonov commented Aug 28, 2017

Please check latest master

@sachithamh
Copy link

@aksonov can you update the package version also pls

@aksonov
Copy link
Owner

aksonov commented Aug 28, 2017

@sachithamadhupa Let's make sure that it fixes issue, could you check?

@sachithamh
Copy link

@aksonov yes I checked it, its working :)

@ValentinBlokhin
Copy link

Waiting for new npm version, thanks

@davojan
Copy link
Contributor

davojan commented Aug 28, 2017

In beta20 default tabBar position for iOS is broken. TabBar is on top by default.

aksonov pushed a commit that referenced this issue Aug 28, 2017
@aksonov
Copy link
Owner

aksonov commented Aug 28, 2017

@davojan Thanks, check beta21

@aksonov aksonov changed the title In the new version of the 'tabbar' on android does not work the 'tabBarPosition' property In the new version of the 'tabbar' does not work the 'tabBarPosition' property Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants