Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

popTo doesn't pop back over 2+ same scenes #2634

Closed
wodCZ opened this issue Nov 20, 2017 · 5 comments
Closed

popTo doesn't pop back over 2+ same scenes #2634

wodCZ opened this issue Nov 20, 2017 · 5 comments
Labels
bug help wanted

Comments

@wodCZ
Copy link
Contributor

wodCZ commented Nov 20, 2017

Version

  • react-native-router-flux v4.0.0-beta.22
  • react-native v0.50.3

Expected behaviour

Please see this PR: #2179
I have same issue that should be fixed by that PR.
Unfortunately this change was overridden by this commit: 92f055e#diff-98b3594cf65eb9acfce1160c51678d6eR55

Steps to reproduce

exactly same as in #2179

having 2 scenes with same key in current stack beaks popTo. Navigation silently fails, without transition to desired scene.
@wmonecke
Copy link

wmonecke commented Nov 20, 2017 •
edited
Loading

I am having this same issue right now, only that I have 4 Scenes which I want to 'popBack' to.
They all have different keys.

Version

  • "react-native-router-flux": "^4.0.0-beta.22"

@aksonov
Copy link
Owner

aksonov commented Jan 4, 2018

@wodCZ Sorry about overriding, could you re-submit this PR again?

@wodCZ
Copy link
Contributor Author

wodCZ commented Jan 4, 2018

@aksonov I wasn't an author of the PR I've referenced (@ulentini was). But I'll have a look if I can re-submit that change.

@ulentini ulentini mentioned this issue Jan 4, 2018
Merged
@ulentini
Copy link
Contributor

ulentini commented Jan 4, 2018

I just resubmitted the PR, hope it helps.

aksonov pushed a commit that referenced this issue Jan 5, 2018
@ulentini @aksonov
Fixed popTo method (again) (#2761)
5102a66 
* Fixed popTo method

popTo method used to fail in case there were a Scene in the stack of the same kind of the current one.

* Fixed popTo method

Fixed popTo method, as referenced in #2634
mvanroon pushed a commit to mvanroon/react-native-router-flux that referenced this issue Feb 15, 2018
@ulentini @mvanroon
Fixed popTo method (again) (aksonov#2761)
8fc5a50 
* Fixed popTo method

popTo method used to fail in case there were a Scene in the stack of the same kind of the current one.

* Fixed popTo method

Fixed popTo method, as referenced in aksonov#2634
@aksonov
Copy link
Owner

aksonov commented Aug 8, 2018

Please try to reproduce it with Example project and latest version 4.0.0-beta.40. Feel free to open if the issue still exists

@aksonov aksonov closed this as completed Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@wodCZ @aksonov @ulentini @wmonecke