Update react-navigation dependency to release version

[kylethebaker]

Is there a reason that the project is depending on React Navigation 1.0.0-beta22? This is 16 releases behind the current version of React Navigation which is now on v1.0.3 and out of the beta/rc stage.

I assume it's due to compatibility issues, have these been identified? I think it would be a good idea to start of list of these kinds of issues so that they can be addressed. Presumably now that react navigation is out of beta there will be less compatibility issues moving forward if we're able to get caught up.

[marcosmartinez7]

I have posted the same issue here #2865

i think that is more important to have compatibility with previous versions, i mean, RNRF beta 24 is using the last react-navigation, and RNRF beta 28 is using 10.0.0-beta22

[aksonov]

Unfortunately newer react navigation versions completely change outer state integration stuff: https://reactnavigation.org/docs/redux-integration.html

PR is welcome but I doubt we can avoid any breaking changes to support newer react navigation version...

[aksonov]

There are more breaking changes coming:
react-navigation/react-navigation#3392

[asciifaceman]

Yeah I've had a ton of issues with everything after 22, I even had to back up my react-native lib to keep everything working right

[marcosmartinez7]

react navigation is preparing v2, do u guys have a plan to keep supporting the RN changes?

can u guys post some guidance in order to help with that?

[aksonov]

@marcosmartinez7 I'm working on new RNRF version that will work with v2 views. For v1, I will try to adopt current RNRF by adding empty addListener (if it would work).

[marcosmartinez7]

Great! let us know if we can colaborate in something in particular.

[aksonov]

It would be great if you could make RNRF work with v1. I can't add where I have to add 'addListener'

[kylethebaker]

I think if we compiled a list of the necessary changes it would make it easier to collaborate. I guess a good place to start would be to bump the version of the dependency and see what breaks?

…

On Mar 16, 2018 5:00 AM, "Pavel Aksonov" ***@***.***> wrote: It would be great if you could make RNRF work with v1. I can't add where I have to add 'addListener' — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2893 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEtO_HHx_JheG2PZFPltrBxEeGOy4_UDks5te39KgaJpZM4SLI3U> .

[aksonov]

Ok, please check latest master and beta.30. Current error is following (Example project) - addListener is missed:

P.S. I've added addListener to navigationStore but it seems not to be enough...

[kylethebaker]

I'll play around with the current master this week and see if I can make any progress, I will use the example projects as a base and then when we start making progress I will try the latest version on my ongoing application.

[aksonov]

RNRF 4.0.0-beta.40 uses latest react-navigation now (2.x)