Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributors wanted! #69

Open
aksonov opened this issue Dec 14, 2015 · 78 comments
Open

Contributors wanted! #69

aksonov opened this issue Dec 14, 2015 · 78 comments

Comments

@aksonov
Copy link
Owner

aksonov commented Dec 14, 2015

I want to make my and your development easier with this component, but i can't spend much time on it. I do my best to make the component better and more robust, thanks for everybody for created issues, it is very valuable!

Unfortunately, number of PRs is minimal, even more, some guys just silently clone the component (even not fork), add some improvements and start promoting it as own one even without preserving copyright (however thanks for mention me as person who "inspire" them ;). I believe it is wrong way for open source development, we need to unite all our efforts to create something really great.

If somebody wants to do many changes (fix issues, write docs/unit tests) without waiting me to accept it, i'm ready to add him as collaborator.

@zebulgar
Copy link
Contributor

I'd be interested! I'm not sure how much time I can dedicate as well but since we're using this library in our production app I will probably be motivated to fix issues that arise

@chetstone
Copy link

I was thinking about trying to help with documentation. There's still an awful lot I don't understand about this component, but perhaps I could take a stab at rewriting the readme and you could review it.

@aksonov
Copy link
Owner Author

aksonov commented Dec 15, 2015

@MITDelian you are welcome (added)

@aksonov
Copy link
Owner Author

aksonov commented Dec 15, 2015

@chetstone You are welcome, help with documentation is really necessary. Btw, I've added you as collaborator as well.

@zebulgar
Copy link
Contributor

@aksonov I thought it might be helpful to have a chat room. I've seen gitter.im used often so I set one up. just might chat some things as I'm learning the component: https://gitter.im/aksonov/react-native-router-flux

@chetstone
Copy link

@MITDelian Thanks for the chatroom. See you there.
@aksonov Thanks. But I'll want you to review docs carefully please before pushing.

@zebulgar
Copy link
Contributor

@chetstone happy to help review as well. I'll spend some time this weekend really trying to understand the component. One of my major goals is to make integration with a pre-existing redux store much easier

@markburns
Copy link
Contributor

Happy to help out. Just picking up a project again that uses this, and found some incompatibility with the latest react-native. Thought I'd browse the issues to see if it's reported and found this issue. Even better if I can just fix it as soon as I understand the problem.

@thachp
Copy link

thachp commented Dec 26, 2015

@aksonov - I will be happy to help out.

@aksonov
Copy link
Owner Author

aksonov commented Jan 4, 2016

@thachp @markburns thanks for help. Please check latest issues and try to create PR for them.

@smallsaucepan
Copy link

Hi @aksonov. I wouldn't mind taking a look at #62 if you still want some help.

@aksonov
Copy link
Owner Author

aksonov commented Jan 15, 2016

@smallsaucepan Yes, please.

@mmazzarolo
Copy link
Contributor

Hi @aksonov, I'm using react-native-router-flux in production and I would like to help when possible.

@aksonov
Copy link
Owner Author

aksonov commented Feb 10, 2016

@mmazzarolo You are welcome to help with README as well as other open issues.

@aksonov
Copy link
Owner Author

aksonov commented Feb 11, 2016

#176 maybe is first priority for now, then #187

@lynndylanhurley
Copy link
Collaborator

Hi @aksonov - I'm sure you've seen it already, but I just pushed a fix for #176.

@aksonov
Copy link
Owner Author

aksonov commented Mar 12, 2016

Who want to help and have time, please check #307

@aksonov
Copy link
Owner Author

aksonov commented Mar 16, 2016

FYI. Collaborators are still wanted (who could regularly answer/resolve issues, propose PRs, review my changes, etc.).

@gustavovnicius
Copy link

@aksonov, I'll be looking at #370. It's being a real pain for me. Do you have some idea that might help?

@charpeni
Copy link
Collaborator

@aksonov I'd be interested in helping you as collaborator by managing issues, propose and review pull requests, documentation and unit tests as well.

FYI, I'm one of the contributors of react-native-simple-router which is a simple and basic integration of the Navigation API.

@aksonov
Copy link
Owner Author

aksonov commented Mar 31, 2016

@charpeni You are welcome! Please check all issues marked with 'help wanted' and submit PR for any.

@markburns
Copy link
Contributor

I think everyone here (including me) was confusing collaborators/contributors. It seems @aksonov is just asking for help but is not asking about adding people as collaborators.

BTW, you might want to follow the model of trusting/adding people based on their contributions here or elsewhere.

E.g. Rubinius is contributor-friendly:
http://www.programblings.com/2008/04/15/rubinius-for-the-layman-part-2-how-rubinius-is-friendly/

It can be rewarding to be listed as a collaborator on a project and the trust can inspire people to contribute even more than the initial contribution.

@aksonov
Copy link
Owner Author

aksonov commented Apr 16, 2016

Actually I really want to add active collaborators as contributors. However so far I see situation when people want to become contributors initially, without any experience with PRs.

Pavel.

16 апр. 2016 г., в 03:58, Mark Burns notifications@github.com написал(а):

I think everyone here (including me) was confusing collaborators/contributors. It seems @aksonov is just asking for help but is not asking about adding people as collaborators.

BTW, you might want to follow the model of trusting/adding people based on their contributions here or elsewhere.

E.g. Rubinius is contributor-friendly:
http://www.programblings.com/2008/04/15/rubinius-for-the-layman-part-2-how-rubinius-is-friendly/

It can be rewarding to be listed as a collaborator on a project and the trust can inspire people to contribute even more than the initial contribution.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@aksonov
Copy link
Owner Author

aksonov commented Apr 20, 2016

@cridenour , @lynndylanhurley, @joenoon Would you like to be collaborators for this project?

@aksonov
Copy link
Owner Author

aksonov commented Apr 20, 2016

@lelandrichardson are you interesting to be collaborator?

@joenoon
Copy link
Collaborator

joenoon commented Apr 20, 2016

@aksonov sure, thanks. i'm using this project quite a bit so i hope to keep contributing regularly.

@aksonov
Copy link
Owner Author

aksonov commented Apr 20, 2016

@philipshurpik Philip, are you still using the component and want to be a collaborator?

@philipshurpik
Copy link
Collaborator

@aksonov yes, we use it in new version of our app )
Would be nice to be a collaborator

@aksonov
Copy link
Owner Author

aksonov commented Jul 20, 2017

@daisydon No, it is not supported yet, PR is welcome (as titleImage prop)

@AlexDM0
Copy link

AlexDM0 commented Jul 20, 2017 via email

@aksonov
Copy link
Owner Author

aksonov commented Jul 20, 2017

@AlexDM0 It is supported already - renderTitle

@rajsuvariya
Copy link

rajsuvariya commented Jul 25, 2017

@aksonov I am interested. But as I don't have too much experience in this technology, so I would like to start with small tasks. Please let me know if there are any.
Thanks

@aksonov
Copy link
Owner Author

aksonov commented Jul 25, 2017

@rajsuvariya Thanks! The most wanted task now is prepare some MobX demo with authentication, but you can start from smaller tasks like answering questions here and submit PR to solve the issues.

@rajsuvariya
Copy link

rajsuvariya commented Jul 27, 2017

I am trying to change some code for my application. I am trying to change it inside myproject's /node_modules/react-native-router-flux/src/Router.js. But the same is not being reflected in the app. Then I tried to add just log inside App component like following, but even that is not working.

  componentDidMount() {
    console.log('dsasd');
    BackHandler.addEventListener('hardwareBackPress', this.onBackPress);
  }

Then I completely removed the code of Router.js then also the app is working fine. How can I change the code inside node_module/router_flux and make it work in my application?

@aksonov
Copy link
Owner Author

aksonov commented Aug 22, 2017

@rajsuvariya Change RNRF package.json to point to src/index.js and restart packager.

@aksonov
Copy link
Owner Author

aksonov commented Aug 22, 2017

I've just marked all tasks anybody could help with PR as 'help wanted'

@mcabs3
Copy link
Collaborator

mcabs3 commented Aug 31, 2017

@aksonov I don't know if I need to be a contributor, but I would love to try and help people with documentation issues and/or usability issues. Let me know what I can do and if I need a role. I will continue to try to get docs up to date as well and eventually can help with some PRs.

Cheers

@aksonov
Copy link
Owner Author

aksonov commented Sep 1, 2017

@mcabs3 Thank you for your help. If you want you can also check tickets with 'help needed' tag

@VahidBo
Copy link

VahidBo commented Sep 7, 2017

@aksonov I'm using react-native-router-flux in my projects so I like to help as much as i can.

@mcabs3
Copy link
Collaborator

mcabs3 commented Sep 11, 2017

@aksonov can you add me as a collaborator please?

@aksonov
Copy link
Owner Author

aksonov commented Sep 11, 2017

@mcabs3 Done. Feel free to close issues - most issues nowadays are questions... Maybe we have to redirect them to stackoverflow.

@onrige
Copy link
Collaborator

onrige commented Sep 28, 2017

@aksonov Hey. I am also interested in help if you still need it. I am already done some PRs and try to help people with issues in free time but it would be great if you will add me as a collaborator.

@daviscabral
Copy link
Collaborator

If needed - I would like to help too - mainly keeping v3 and helping people around it - not sure if is something that you still wish - but since I see a lot of folks still using it, at least maintenance for a few basic issues would be nice while a major upgrade can't be done in most of the projects. Thoughts?

@aksonov
Copy link
Owner Author

aksonov commented Oct 21, 2017

@onrige Thanks! Just sent you the invitation.

@aksonov
Copy link
Owner Author

aksonov commented Oct 21, 2017

@daviscabral Could you show me your PRs first? v3 support would be great!

@daviscabral
Copy link
Collaborator

@aksonov sure - no worries. Just opened #2532 with a few changes related to react 16.0.0.

@mvanroon
Copy link
Contributor

Count me in!

I believe one important thing to be done is manage the questions being asked here in github in the form of issues. They should be asked on gitter or stackoverflow. Maybe we could also add gh-pages and add some more examples and common problems/faq there? I’d be more than happy to help you out there

@aksonov
Copy link
Owner Author

aksonov commented Oct 28, 2017 via email

@aksonov
Copy link
Owner Author

aksonov commented Aug 10, 2018

Dear maintainers and supporters, I have vacation until the end of August. You are welcome to answer issues, submit/review/merge PRs, etc.

@daviscabral
Copy link
Collaborator

Thank you and have a great time!

@aksonov
Copy link
Owner Author

aksonov commented Jan 4, 2019

If someone still wants to help, he can choose "help wanted" tag and work. Also I can pay for some issues from my opencollective budget.

@darrencruse
Copy link

I noticed the issue about the current RNRF not being up to date with the latest react-navigation v3, as well as this issue about needing contributors, and I also noticed react-navigation issues about needing contributors, and also wanting to add a simpler api.

My question: has there ever been talk of teaming up and merging the two libraries?

@aksonov
Copy link
Owner Author

aksonov commented Mar 13, 2019

@darrencruse I talked with some guys from react-navigation team two years ago. They don't want to use JSX as route declaration like RNRF does. However we also discussed possible splitting react-navigation into many modules (separate for router, separate for tabs, etc.), so RNRF could be implemented as router for react-navigation v3 now

gvlamadrid pushed a commit to gvlamadrid/react-native-router-flux that referenced this issue Jun 20, 2019
…EventWithCustomDimensionValues

 - implement trackMultiProductsPurchaseEventWithCustomDimensionValues
@aksonov
Copy link
Owner Author

aksonov commented Apr 23, 2020

Help with RNRF v5 is needed:
#3655

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests