Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passing down wrong overlay navigation state in OverlayNavigator #2422

Merged
merged 1 commit into from
Oct 10, 2017

Conversation

wsxyeah
Copy link
Contributor

@wsxyeah wsxyeah commented Sep 24, 2017

We shouldn't pass the down the state directly to the overlay children,
instead, pass the corresponding state in state.routes.

This bug also caused the issue mentioned in #2407.

@mcabs3
Copy link
Collaborator

mcabs3 commented Sep 27, 2017

Please fix your lint errors and we can start the review process.

@mcabs3
Copy link
Collaborator

mcabs3 commented Sep 27, 2017

/home/circleci/react-native-router-flux/src/OverlayNavigator.js
  25:26  error  Trailing spaces not allowed  no-trailing-spaces
  31:17  error  'routeName' is not defined   no-undef
  31:35  error  Trailing spaces not allowed  no-trailing-spaces
  31:35  error  Missing semicolon            semi

@wsxyeah
Copy link
Contributor Author

wsxyeah commented Sep 29, 2017

@mcabs3 fixed

@aksonov aksonov merged commit 3c81707 into aksonov:master Oct 10, 2017
mvanroon pushed a commit to mvanroon/react-native-router-flux that referenced this pull request Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants