Upd deps: react-navigation to beta-15, rm RN-button, upd mobx & mobx-react #2584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesha-antonov
changed the title
|
Please update also yarn.lock, also react-navigation.beta.17 was published... Maybe we could use something like '*' to install latest beta automatically? |
|
@aksonov Ok! one moment. There was style issue with navBar in beta.16. react-navigation team fixed it Also I'm not confident enough in react-navigation usage or RNRF source code to be sure if it's a good idea or we should manually check every release of react-navigation before update. |
|
What do you think about to update mobx & mobx-react? |
|
I've looked through mobx changelog. Nothing breaking |
kesha-antonov
changed the title
mvanroon
pushed a commit
to mvanroon/react-native-router-flux
that referenced
this pull request
Feb 15, 2018
…react (aksonov#2584) * upd deps * upd pkgs * upd RN to fix test * upd mobx & mobx-react
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.