Compatibility with RN 0.52.1 for RNRF v3 #2853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you check conflicts? |
|
Conflicts resolved |
|
So, looks like there was never a version published to npm that includes this compatibility? Latest I see for 3.x is 3.43.0 which was released in October, months before this was merged. Can we get this published as 3.44.0? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in my company I was asked to update our app to the latest version of RN, to achieve it I found many errors with the V4 of this library also we did not want to release to production with beta libraries, so I modified some things from version 3.38. 0 of your library to work with RN 0.52.1, basically the changes are to add the import of the PropTypes from your own package.
It could be something like a version 3.38.1, I do this pull requests in case it would serve someone in the future.