Update README.md #3275
Merged
Update README.md #3275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aksonov
requested changes
Sep 20, 2018
README.md
Outdated
| @@ -78,10 +80,10 @@ react-native run-ios | |||
| * in case of handler's failure, `failure` prop (if defined) will be run. | |||
| * Combining `onEnter`, `onExit`, `success`, and `failure` makes patterns like authentication, data validation, and conditional transitions simple and intuitive. | |||
| * [MobX](https://mobx.js.org/)-friendly: all scenes are wrapped with `observer`. You may subscribe to `navigationStore` (`Actions` in v3) and observe current navigation state. Not applicable to Redux. | |||
| * Flexible nav bar customization not currently allowed by React Navigation: | |||
| * Flexible Nav bar customization ,currently not allowed by React Navigation: | |||
| https://github.com/react-community/react-navigation/issues/779 | |||
There was a problem hiding this comment.
nope,it got misplaced !
|
Thanks! |
ps0305
commented
Sep 20, 2018
README.md
Outdated
| @@ -78,10 +80,10 @@ react-native run-ios | |||
| * in case of handler's failure, `failure` prop (if defined) will be run. | |||
| * Combining `onEnter`, `onExit`, `success`, and `failure` makes patterns like authentication, data validation, and conditional transitions simple and intuitive. | |||
| * [MobX](https://mobx.js.org/)-friendly: all scenes are wrapped with `observer`. You may subscribe to `navigationStore` (`Actions` in v3) and observe current navigation state. Not applicable to Redux. | |||
| * Flexible nav bar customization not currently allowed by React Navigation: | |||
| * Flexible Nav bar customization ,currently not allowed by React Navigation: | |||
| https://github.com/react-community/react-navigation/issues/779 | |||
There was a problem hiding this comment.
nope,it got misplaced !
README.md
Outdated
| @@ -78,10 +80,10 @@ react-native run-ios | |||
| * in case of handler's failure, `failure` prop (if defined) will be run. | |||
| * Combining `onEnter`, `onExit`, `success`, and `failure` makes patterns like authentication, data validation, and conditional transitions simple and intuitive. | |||
| * [MobX](https://mobx.js.org/)-friendly: all scenes are wrapped with `observer`. You may subscribe to `navigationStore` (`Actions` in v3) and observe current navigation state. Not applicable to Redux. | |||
| * Flexible nav bar customization not currently allowed by React Navigation: | |||
| * Flexible Nav bar customization ,currently not allowed by React Navigation: | |||
There was a problem hiding this comment.
Flexible Nav bar customization, currently not allowed by React Navigation:
There was a problem hiding this comment.
I see comma right before 'currently', so now it is "Flexible Nav bar customization ,currently not allowed by React Navigation:"
daviscabral
added a commit
that referenced
this pull request
Sep 21, 2018
* master: Update README.md (#3275)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.