New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API authentication method call deprecated #97
Comments
Same here, also got the GitHub notification mails... |
It would be great if someone forks this and fixes this issue. There are no maintainers on this project anymore it appears, and this twice a week email will be scary for my end-users. If someone does fork this to fix this, please comment here so we can be informed. |
I'm working on this now. The main problem is Github now requires you to send the username corresponding to the access token, which means we need to change the project API. |
@kevinburkemeter actually you don't: sending the token base64 encoded as a basic authentication header works. You can also do |
Oh! OK, let me try that. |
Port the Client implementation to use github.com/kevinburke/rest, which gives us inspection of the HTTP request/response, user agents and basic auth out of the box, without needing to set those every time. Most of the rest of the code remains the same. Move the VERSION constant into the github subpackage (from the main package) so we can use it there. Fixes github-release#95. Fixes github-release#97.
OK, just pushed a fix to github.com/meterup/github-release, as well as a 0.7.4 release. Please try it out! https://github.com/meterup/github-release/releases/tag/v0.7.4 |
Same API, no need to pass in an auth username, but you can if you want. |
I had an older fork at https://github.com/gdm85/github-release; I will also add support like @kevinburkemeter did but without introducing the |
@kevinburkemeter I don't know why you disabled issues on your repository, but I thought it was supposed to be a drop-in replacement. My command, which has worked for years until this day, does not work on your fork.
Looking forward to trying @gdm85's fork instead. |
Yes, the goal was to make it a drop in replacement. Considering you're getting something for free, and I have no obligation to help anyone in this situation, I'm a little frustrated with the tone you're taking. I didn't touch the Makefile at all, so I'm not sure why it's broken. The file you are trying to run needs to be executable though, which is why you are getting "Permission denied," it has nothing to do with the code changes. Try running |
I suspect it has to do with b61ce1a which was added after 0.7.2 was released. So, drop in replacement for the untagged master version of the github-release project. Anyway, I'll push a fix later today. |
I may be inclined to just look at the script we have this in, and see if it's easy enough to replace it with |
The best would be to use GitHub official CLI, there is no doubt. Until that I have updated my fork at https://github.com/gdm85/github-release and tagged v0.8.0 for the working version that adds support for NOTE 1: please do some thorough testing before putting this into your important workflows; I have tested only the following:
And assumed that the rest are working correctly as well. NOTE 2: do not use |
@Bilge I just confirmed that the issue you ran into was introduced in the last commit on the original project, in 2017, so it's been there for three years. The reason you haven't seen it before is that commit never made it into a release version. In any event, I just pushed a fix to meterup/github-release@c3c29b7, which is present in v0.7.5. |
github-release/github-release#97 Signed-off-by: tsaikd <tsaikd@gmail.com>
Dear @kevinburkemeter, thanks for picking up the work on We are happy to see it has been you. Updating the documentation was easy (hiveeyes/terkin-datalogger@8c58bd8). So, thanks to @aktau for conceiving this fine program and to you for bringing in important maintenance patches. With kind regards, |
GitHub has started emailing users who call their API with the deprecated URL authorization scheme.
More information.
The text was updated successfully, but these errors were encountered: