Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: support no_std environments #97

Merged
merged 7 commits into from May 10, 2023

Conversation

bigherc18
Copy link
Contributor

No description provided.

src/without_std.rs Outdated Show resolved Hide resolved
src/without_std.rs Outdated Show resolved Hide resolved
src/with_std.rs Outdated Show resolved Hide resolved
src/without_std.rs Outdated Show resolved Hide resolved
src/with_std.rs Outdated Show resolved Hide resolved
src/with_std.rs Outdated Show resolved Hide resolved
@bigherc18 bigherc18 force-pushed the feat/support_no_std branch 2 times, most recently from 5f12b06 to d614df0 Compare February 25, 2023 13:22
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/with_std.rs Show resolved Hide resolved
src/without_std.rs Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@akubera
Copy link
Owner

akubera commented Feb 26, 2023

This changes the minimum supported rust version to 1.43, by my estimation. Though I don't really like we're straying away from num-bigint's 1.31, I don't think too many people will be upset by dropping versions old than 3 years.

Let's update version in the README (last line)

@bigherc18
Copy link
Contributor Author

@akubera

Let's update version in the README (last line)

I can't see any version mentioned in the README

@bigherc18
Copy link
Contributor Author

bigherc18 commented Feb 27, 2023

Edit: Fixed

This changes the minimum supported rust version to 1.43

We can also avoid this easily, because it comes from using siphasherand it's only used during tests, we should either replace the siphasher with a crate that support edition = 2015 or only run the tests that uses hash when on std

What do you think ?

@bigherc18 bigherc18 marked this pull request as ready for review February 27, 2023 10:22
@bigherc18
Copy link
Contributor Author

@akubera would you please take a look again, we no longer need to change the minimum supported version

We're using your bigdecimal-rs library in our projects and we need the no_std support, we'd like you to merge this PR instead of maintaining our own fork

@eranrund
Copy link

We would also love to see this gets merged! Any chance that might happen?

@tdelabro
Copy link

@akubera What is preventing us to merge?

@akubera akubera force-pushed the master branch 2 times, most recently from dbdae69 to 24d9ae0 Compare May 9, 2023 06:38
@akubera akubera changed the base branch from master to dev/v0.4.0 May 9, 2023 06:48
@akubera akubera changed the base branch from dev/v0.4.0 to feature/no-std May 10, 2023 02:45
@akubera akubera merged commit b837f73 into akubera:feature/no-std May 10, 2023
@akubera akubera mentioned this pull request May 10, 2023
@akubera
Copy link
Owner

akubera commented May 21, 2023

I think we have to require alloc so I'm removing that optional feature.

Unless I'm missing something, num-bigint requires alloc, so we're not restricting our environments any more than our dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants