Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated makefile to automatically configure systemd and rsyslog #32

Merged
merged 2 commits into from Sep 5, 2020

Conversation

akuker
Copy link
Member

@akuker akuker commented Sep 4, 2020

Added the rsyslog and systemd configuration files to the 'src' directory. Updated makefile to automatically install these files, then restart the appropriate services.

The new build procedure will be:

make clean
make all
sudo make install

@akuker akuker requested review from phrax0 and sfiera September 4, 2020 01:38

$(DOC_DIR)/%_man_page.txt : $(DOC_DIR)/%.1
@echo "!! ------ THIS FILE IS AUTO_GENERATED! DO NOT MANUALLY UPDATE!!!" > $@
@echo "!! ------ The native file is $(notdir $<). Re-run 'make docs' after updating\n\n" >> $@
man -l $< | col -bx >> $@

$(SYSTEMD_CONF) : $(OS_FILES)/$(notdir $(SYSTEMD_CONF))
cp $< $@
systemctl enable rascsi.service
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather not start services here:

  • It’s not something I expect make install to do
  • It’s not appropriate in certain contexts, like building packages or archives

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Removed.

@akuker
Copy link
Member Author

akuker commented Sep 4, 2020

I've also added a "help" target so that users can run "make help" if they don't RTFM.

@akuker akuker merged commit a50fcbd into master Sep 5, 2020
@akuker akuker deleted the setup_improvment branch September 5, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants