WIP: Finish Ethereum Wire Protocol implementation #19
Conversation
|
@preston-evans98 Hey, thanks for the PR! Is this still a draft you will be working on? |
|
I do plan to keep working on it! Unfortunately, I’m traveling at the moment and likely won’t make much progress for a few days. If you’d prefer to merge as is, I’m happy to make it a full PR and submit follow ups to fill out the code coverage and fix the decoding bugs. |
|
Take your time, just make sure to mark it as ready to review when you're done. |
|
This commit is ready to merge as soon as rust-ethereum/ethereum#19 is resolved! |
vorot93
force-pushed
the
master
branch
2 times, most recently
from
c166566
to
6e8b74e
Compare
|
Hey, I'm interested in using some of this - what's left to do on this PR? Could I help out in any way? |
Not much, last I checked! I started a new job and had to get open source contributions approved with legal, so this just fell by the wayside. It is possible that some dependencies have changed though, so there may be some reformatting required. I'll try to take a look tonight. |
|
@vorot93 would you mind kicking off the approval workflow when you have a minute? |
@preston-evans98 if you rebase onto master, solve conflicts, and then force push, the workflow should be triggered automatically. Currently GH shows that it has some conflicts, so a manual rebase is still needed. Please try to squash and rebase instead of merging. |
preston-evans98
force-pushed
the
master
branch
from
3dc4620
to
bbbe819
Compare
Implement all message types. Test all messages which have EIP2481 test cases Enable decoding of all tested messages
preston-evans98
force-pushed
the
master
branch
from
bbbe819
to
8b10160
Compare
|
@battlmonstr I've rebased and squashed. I'm not seeing any conflicts on my end but it doesn't look like CI reran automatically. Do you see anything I've missed? |
|
@preston-evans98 thanks. Yes, the CI run approval was required for you. Now the checks are in progress ⏳ |
Implement each message type.
Implement some tests cases from EIP 2481