Skip to content

Commit

Permalink
Added unit tests, closes #1
Browse files Browse the repository at this point in the history
  • Loading branch information
akupila committed Mar 11, 2016
1 parent 2d52b87 commit ec123e8
Show file tree
Hide file tree
Showing 2 changed files with 160 additions and 2 deletions.
7 changes: 5 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "Node task runner of async jobs with nice interface",
"main": "index.js",
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1",
"test": "mocha",
"lint": "eslint ."
},
"repository": {
Expand All @@ -29,7 +29,10 @@
"eslint": "2.3.0",
"eslint-config-standard": "5.1.0",
"eslint-plugin-promise": "1.1.0",
"eslint-plugin-standard": "1.3.2"
"eslint-plugin-standard": "1.3.2",
"expect.js": "0.3.1",
"mocha": "2.4.5",
"sinon": "1.17.3"
},
"dependencies": {
"charm": "1.0.0",
Expand Down
155 changes: 155 additions & 0 deletions test/tests.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,155 @@
/* eslint-env mocha */

'use strict'

process.env.NODE_ENV = 'test'

const bucketlist = require('..')
const expect = require('expect.js')
const sinon = require('sinon')

describe('bucketlist', () => {
it('should run tasks in sequence', (done) => {
let firstCalled = false
let secondCalled = false

const first = () => {
if (secondCalled) {
throw new Error('Second called before first')
}
firstCalled = true
return Promise.resolve()
}

const second = () => {
if (!firstCalled) {
throw new Error('First not called before second')
}
secondCalled = true
return Promise.resolve()
}

bucketlist([
{ name: '', run: first },
{ name: '', run: second }
])
.then(() => {
expect(firstCalled).to.be(true)
expect(secondCalled).to.be(true)
done()
})
.catch(done)
})

it('should run tasks in parallel', (done) => {
const clock = sinon.useFakeTimers()
const delay = 5000
const makeDelayed = () => ({
name: 'Delayed',
run: () => new Promise((resolve, reject) => {
setTimeout(resolve, delay)
})
})

let resolved = false

bucketlist([
[
makeDelayed(),
makeDelayed(),
makeDelayed(),
makeDelayed(),
makeDelayed()
]
])
.then(() => {
resolved = true
})

clock.tick(delay)
clock.restore()

setImmediate(() => {
if (!resolved) {
return done('Parallel didn\'t resolve in time')
}
done()
})
})

it('should return data', (done) => {
bucketlist([
{
id: 'source',
name: 'A',
run: () => Promise.resolve({ value: 42 })
},
{
name: 'B',
run: (log, data) => new Promise((resolve, reject) => {
expect(data.source.value).to.be(42)
resolve()
})
}
])
.then(() => {
done()
})
.catch(done)
})

it('should fail on first error', (done) => {
bucketlist([
{
name: 'Error',
run: () => Promise.resolve()
},
{
name: 'Second',
run: () => {
throw new Error('run called after error')
}
}
])
.then(() => {
done('Did not exit on error')
})
.catch(() => {
done()
})
})

it('should fail gracefully when run throws', (done) => {
bucketlist([
{
name: 'Throws',
run: () => {
throw new Error('Some error')
}
}
])
.then(() => done('Exited successfully'))
.catch((error) => {
expect(error.message).to.eql('Some error')
done()
})
})

it('should fail if promise rejects', (done) => {
bucketlist([
{
name: 'rejects',
run: () => new Promise((resolve, reject) => {
setTimeout(() => {
reject('Error message')
}, 10)
})
}
])
.then(() => done('Exited successfully'))
.catch((error) => {
expect(error).to.eql('Error message')
done()
})
})
})

0 comments on commit ec123e8

Please sign in to comment.