Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible to hide line numbers but keep collapsible sections? #159

Closed
cosmotek opened this issue Jan 24, 2023 · 2 comments · Fixed by #167
Closed

Possible to hide line numbers but keep collapsible sections? #159

cosmotek opened this issue Jan 24, 2023 · 2 comments · Fixed by #167
Assignees
@yescorp
Labels
P3

Comments

@cosmotek
Copy link

The title pretty much says it all. I've tried to do this by messing with the line number styling but it appears it also effects the collapsible buttons too.

Thanks! Keep up the great work. This package is amazing.
@alexeyinkin alexeyinkin added the P3 label Jan 26, 2023
@alexeyinkin
Copy link
Contributor

@cosmotek thanks for the suggestion, we will do it.

  1. Soft rename LineNumberStyle to GutterStyle.
  2. Add GutterStyle.showLineNumbers as bool.

@yescorp yescorp mentioned this issue Jan 26, 2023
Merged
alexeyinkin added a commit that referenced this issue Jan 27, 2023
@alexeyinkin
Code style (#159)
3bfbd20
alexeyinkin added a commit that referenced this issue Jan 27, 2023
@yescorp @alexeyinkin
Gutter customization (#167)
a71e934 
* WIP

* small rearrangements

* margin adjustments, example added

* variable replaced with getter

* example 03 restored

* ignores removed

* example 4 moved to example 3

* checkbox color changed to transparent white from grey

* GutterStyle renamed instead of creating new file

* GutterStyle.none added

* padding changed

* ignores inlined

* import fixes

* example adjustments

* Code style (#159)

Co-authored-by: Yestay Tastanov <yestay@Yestays-MacBook-Pro.local>
Co-authored-by: Alexey Inkin <alexey.inkin@akvelon.com>
@cosmotek
Copy link
Author

cosmotek commented Jan 27, 2023 •
edited

Is this released?

Edit: Nevermind. I see this is included in v0.2.9.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yescorp yescorp

Labels
P3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Gutter customization akvelon/flutter-code-editor
3 participants
@alexeyinkin @cosmotek @yescorp