issue 47. tests for scala foldable blocks #75
Conversation
| expect(actual, matcher); | ||
| }); | ||
|
|
||
| test('Join intersecting blocks in list with two not intersecting blocks', |
There was a problem hiding this comment.
Do we need this test if we have the one after it?
There was a problem hiding this comment.
We do, because it's edge case. Two items are minimal available count for intersecting
There was a problem hiding this comment.
Does it work differently internally? If no, then my experience is that less tests on similar inputs is preferred. This is because if we change the API we will have to refactor tests which is more tedious than refactoring code.
| expect(actual, matcher); | ||
| }); | ||
|
|
||
| test('Mixed blocks will join correctly', () { |
There was a problem hiding this comment.
This test mostly repeats the one above. You can add the last block from this test there, and the same inputs will be covered.
There was a problem hiding this comment.
I'd like to test edge cases separately from another logic
lib/src/folding/foldable_block.dart
Outdated
| for (int i = 1; i < length; i++) { | ||
| final currentBlock = this[i]; | ||
| final previousBlock = this[i - 1]; | ||
| if (currentBlock.intersects(previousBlock)) { |
There was a problem hiding this comment.
intersects(other) is not needed at all. Just check if previous.endLine >= current.startLine && previous.endLine < current.endLine or maybe make a method that encapsulates this (but I am struggling to come up with a name, maybe intersectsWithEnd(int))
There was a problem hiding this comment.
This logic falls on this test:
_Example(
'Python. Nested highlight blocks',
code: '''
a = [[
5
]
]''',
expected: [
_FB(startLine: 0, endLine: 2, type: _T.brackets),
_FB(startLine: 0, endLine: 3, type: _T.brackets),
],
),
There was a problem hiding this comment.
Let's disallow two blocks to start on the same line because we can only have one folding button per line. Only the outer block of the two should survive.
| FB(startLine: 6, endLine: 12, type: FBT.braces), | ||
| FB(startLine: 7, endLine: 9, type: FBT.parentheses), | ||
| FB(startLine: 10, endLine: 11, type: FBT.parentheses), | ||
| FB(startLine: 0, endLine: 6, type: FBT.braces), // 0 |
There was a problem hiding this comment.
Align the digits please.
No description provided.