Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(window): reattach overlay after window expand #1022

Merged
merged 3 commits into from
Nov 29, 2018
Merged

fix(window): reattach overlay after window expand #1022

merged 3 commits into from
Nov 29, 2018

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Nov 27, 2018

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Fixes #1003

@yggg yggg requested a review from Tibing November 27, 2018 11:21
@yggg yggg mentioned this pull request Nov 27, 2018
2 tasks
@codecov
Copy link

codecov bot commented Nov 29, 2018

Codecov Report

Merging #1022 into master will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #1022      +/-   ##
==========================================
- Coverage   76.88%   76.86%   -0.02%     
==========================================
  Files         200      200              
  Lines        5975     5983       +8     
  Branches      455      456       +1     
==========================================
+ Hits         4594     4599       +5     
- Misses       1273     1276       +3     
  Partials      108      108
Impacted Files Coverage Δ
...mework/theme/components/window/window.component.ts 79.31% <100%> (+0.73%) ⬆️
.../theme/components/cdk/overlay/overlay-container.ts 85.71% <50%> (-7.39%) ⬇️

@Tibing Tibing merged commit 4b9c648 into akveo:master Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Window bugs on minimize/maximize
3 participants