Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(search): emit activate and deactivate events #1162

Merged
merged 1 commit into from
Jan 16, 2019
Merged

fix(search): emit activate and deactivate events #1162

merged 1 commit into from
Jan 16, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Jan 16, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Emit search activate and deactivate events when search opened from NbSearchComponent.

@yggg yggg requested a review from nnixaa January 16, 2019 14:52
@codecov
Copy link

codecov bot commented Jan 16, 2019

Codecov Report

Merging #1162 into master will decrease coverage by 0.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #1162      +/-   ##
==========================================
- Coverage   78.86%   78.84%   -0.02%     
==========================================
  Files         200      200              
  Lines        6066     6070       +4     
  Branches      469      469              
==========================================
+ Hits         4784     4786       +2     
- Misses       1167     1169       +2     
  Partials      115      115
Impacted Files Coverage Δ
...mework/theme/components/search/search.component.ts 46.42% <50%> (+0.13%) ⬆️

@yggg yggg added WIP and removed WIP labels Jan 16, 2019
@nnixaa nnixaa merged commit 67c5718 into akveo:master Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants