Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alert): Eva theme #1406

Merged
merged 9 commits into from
Apr 22, 2019
Merged

feat(alert): Eva theme #1406

merged 9 commits into from
Apr 22, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Apr 21, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

BREAKING CHANGE:

NbAlertComponent 'closableValue' replaced with 'closable'.

All NbAlertComponent static fields removed.
SIZE_XXSMALL, SIZE_XSMALL, SIZE_SMALL, SIZE_MEDIUM, SIZE_LARGE,
SIZE_XLARGE, SIZE_XXLARGE, STATUS_ACTIVE, STATUS_DISABLED,
STATUS_PRIMARY, STATUS_INFO, STATUS_SUCCESS, STATUS_WARNING,
STATUS_DANGER, ACCENT_ACTIVE, ACCENT_DISABLED, ACCENT_PRIMARY,
ACCENT_INFO, ACCENT_SUCCESS, ACCENT_WARNING, ACCENT_DANGER,
OUTLINE_ACTIVE, OUTLINE_DISABLED, OUTLINE_PRIMARY, OUTLINE_INFO,
OUTLINE_SUCCESS, OUTLINE_WARNING, OUTLINE_DANGE.

Active status removed.
Disabled become input instead of status value. Disabled class renamed to
'disabled'.

NbAlertComponent 'hasAccent', 'hasStatus', 'hasOutline' getters removed.

Status class names changed to 'status-[status-name]'.
Outline class names changed to 'outline-[status-name]'.
Accent class names changed to 'accent-[status-name]'.

Following theme properties were renamed:

alert-font-size -> alert-text-font-size
alert-line-height -> alert-text-line-height
alert-font-weight -> alert-text-font-weight
alert-fg -> alert-text-color
alert-bg -> alert-background-color
alert-disabled-bg -> alert-disabled-background-color
alert-disabled-fg -> alert-disabled-text-color
alert-primary-bg -> alert-primary-background-color
alert-info-bg -> alert-info-background-color
alert-success-bg -> alert-success-background-color
alert-warning-bg -> alert-warning-background-color
alert-danger-bg -> alert-danger-background-color
alert-height-xsmall -> alert-tiny-height
alert-height-small -> alert-small-height
alert-height-medium -> alert-medium-height
alert-height-large -> alert-medium-padding
alert-height-xlarge -> alert-large-height
alert-closable-padding -> alert-closable-start-padding
alert-margin -> alert-bottom-margin

Following theme properties removed:
alert-outline-fg
alert-active-bg
alert-height-xxsmall
alert-height-xxlarge
alert-button-padding

BREAKING CHANGE:

NbAlertComponent 'closableValue' replaced with 'closable'.
BREAKING CHANGE:

All NbAlertComponent static fields removed.
SIZE_XXSMALL, SIZE_XSMALL, SIZE_SMALL, SIZE_MEDIUM, SIZE_LARGE,
SIZE_XLARGE, SIZE_XXLARGE, STATUS_ACTIVE, STATUS_DISABLED,
STATUS_PRIMARY, STATUS_INFO, STATUS_SUCCESS, STATUS_WARNING,
STATUS_DANGER, ACCENT_ACTIVE, ACCENT_DISABLED, ACCENT_PRIMARY,
ACCENT_INFO, ACCENT_SUCCESS, ACCENT_WARNING, ACCENT_DANGER,
OUTLINE_ACTIVE, OUTLINE_DISABLED, OUTLINE_PRIMARY, OUTLINE_INFO,
OUTLINE_SUCCESS, OUTLINE_WARNING, OUTLINE_DANGE.

Active status removed.
Disabled become input instead of status value. Disabled class renamed to
'disabled'.

NbAlertComponent 'hasAccent', 'hasStatus', 'hasOutline' getters removed.

Status class names changed to 'status-[status-name]'.
Outline class names changed to 'outline-[status-name]'.
Accent class names changed to 'accent-[status-name]'.
BREAKING CHANGE:

Following theme properties were renamed:

alert-font-size -> alert-text-font-size
alert-line-height -> alert-text-line-height
alert-font-weight -> alert-text-font-weight
alert-fg -> alert-text-color
alert-bg -> alert-background-color
alert-disabled-bg -> alert-disabled-background-color
alert-disabled-fg -> alert-disabled-text-color
alert-primary-bg -> alert-primary-background-color
alert-info-bg -> alert-info-background-color
alert-success-bg -> alert-success-background-color
alert-warning-bg -> alert-warning-background-color
alert-danger-bg -> alert-danger-background-color
alert-height-xsmall -> alert-tiny-height
alert-height-small -> alert-small-height
alert-height-medium -> alert-medium-height
alert-height-large -> alert-medium-padding
alert-height-xlarge -> alert-large-height
alert-closable-padding -> alert-closable-start-padding
alert-margin -> alert-bottom-margin

Following theme properties removed:
alert-outline-fg
alert-active-bg
alert-height-xxsmall
alert-height-xxlarge
alert-button-padding
@yggg yggg requested a review from nnixaa April 21, 2019 09:20
}
&.accent-danger {
border-top-color: nb-theme(alert-danger-bg);
&.disabled {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need a disabled alert. It was a part of available statuses in Nebular 3, let's remove it now.
Unless you see a usecase.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in 375931a

@codecov
Copy link

codecov bot commented Apr 22, 2019

Codecov Report

Merging #1406 into next will decrease coverage by 0.07%.
The diff coverage is 94.59%.

@@            Coverage Diff             @@
##             next    #1406      +/-   ##
==========================================
- Coverage   82.76%   82.68%   -0.08%     
==========================================
  Files         238      238              
  Lines        7280     7227      -53     
  Branches      637      637              
==========================================
- Hits         6025     5976      -49     
+ Misses       1068     1064       -4     
  Partials      187      187
Impacted Files Coverage Δ
...mework/theme/components/search/search.component.ts 79.48% <ø> (ø) ⬆️
...ramework/theme/components/alert/alert.component.ts 96.36% <94.59%> (+1.91%) ⬆️

@yggg yggg merged commit 812797f into akveo:next Apr 22, 2019
yggg added a commit that referenced this pull request May 27, 2019
BREAKING CHANGE:

NbAlertComponent 'closableValue' replaced with 'closable'.

All NbAlertComponent static fields removed.
SIZE_XXSMALL, SIZE_XSMALL, SIZE_SMALL, SIZE_MEDIUM, SIZE_LARGE,
SIZE_XLARGE, SIZE_XXLARGE, STATUS_ACTIVE, STATUS_DISABLED,
STATUS_PRIMARY, STATUS_INFO, STATUS_SUCCESS, STATUS_WARNING,
STATUS_DANGER, ACCENT_ACTIVE, ACCENT_DISABLED, ACCENT_PRIMARY,
ACCENT_INFO, ACCENT_SUCCESS, ACCENT_WARNING, ACCENT_DANGER,
OUTLINE_ACTIVE, OUTLINE_DISABLED, OUTLINE_PRIMARY, OUTLINE_INFO,
OUTLINE_SUCCESS, OUTLINE_WARNING, OUTLINE_DANGE.

Active status removed.
Disabled become input instead of status value. Disabled class renamed to
'disabled'.

NbAlertComponent 'hasAccent', 'hasStatus', 'hasOutline' getters removed.

Status class names changed to 'status-[status-name]'.
Outline class names changed to 'outline-[status-name]'.
Accent class names changed to 'accent-[status-name]'.

Following theme properties were renamed:

alert-font-size -> alert-text-font-size
alert-line-height -> alert-text-line-height
alert-font-weight -> alert-text-font-weight
alert-fg -> alert-text-color
alert-bg -> alert-background-color
alert-disabled-bg -> alert-disabled-background-color
alert-disabled-fg -> alert-disabled-text-color
alert-primary-bg -> alert-primary-background-color
alert-info-bg -> alert-info-background-color
alert-success-bg -> alert-success-background-color
alert-warning-bg -> alert-warning-background-color
alert-danger-bg -> alert-danger-background-color
alert-height-xsmall -> alert-tiny-height
alert-height-small -> alert-small-height
alert-height-medium -> alert-medium-height
alert-height-large -> alert-medium-padding
alert-height-xlarge -> alert-large-height
alert-closable-padding -> alert-closable-start-padding
alert-margin -> alert-bottom-margin

Following theme properties removed:
alert-outline-fg
alert-active-bg
alert-height-xxsmall
alert-height-xxlarge
alert-button-padding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants