Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NbSidebarService onExpand() don't get event when sidebar is expanded by click on nb-menu item with submenu #1432

Closed
1 task done
przemekpobuta opened this issue Apr 29, 2019 · 0 comments · Fixed by #1897
Closed
1 task done

Comments

@przemekpobuta
Copy link

przemekpobuta commented Apr 29, 2019

Issue type

I'm submitting a ... (check one with "x")

  • bug report

Issue description

Current behavior:
Example from ngx-admin: NbSidebarComponent is compacted state, when clicked on menu (NbMenuComponent) item (only icon in compacted sidebar state) with nested items, then sidebar expand, but any event from available in NbSidebarService Observables isn't fired.

Expected behavior:
In my opinion method onExpand() from NbSidebarService should emit event after sidebar changed state from e.g. compacted to expanded. Or more appropriate, any way to track sidebar state.

Angular, Nebular

@nebular/theme: 3.4.2
@angular: 7.*.*

@yggg yggg added this to To do in Quality via automation Jul 22, 2019
@yggg yggg moved this from To do to Review in progress in Quality Aug 9, 2019
Quality automation moved this from Review in progress to Done Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Quality
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants