Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(toastr): add duplicates behavior #1628

Merged
merged 4 commits into from
Jun 24, 2019

Conversation

elupanov
Copy link
Member

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Adds toaster service duplication behaviour

@codecov
Copy link

codecov bot commented Jun 21, 2019

Codecov Report

Merging #1628 into master will increase coverage by 0.16%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #1628      +/-   ##
==========================================
+ Coverage   83.29%   83.46%   +0.16%     
==========================================
  Files         231      231              
  Lines        7543     7552       +9     
  Branches      658      661       +3     
==========================================
+ Hits         6283     6303      +20     
+ Misses       1069     1055      -14     
- Partials      191      194       +3
Impacted Files Coverage Δ
...framework/theme/components/toastr/toastr-config.ts 95% <100%> (+0.26%) ⬆️
...ramework/theme/components/toastr/toastr.service.ts 85.32% <81.81%> (+12.05%) ⬆️

@nnixaa
Copy link
Collaborator

nnixaa commented Jun 24, 2019

@elupanov we would need some tests for this new functionality

@nnixaa nnixaa changed the title feat(toastr): add duplicates behaviour feat(toastr): add duplicates behavior Jun 24, 2019
@nnixaa nnixaa merged commit 4ab5037 into akveo:master Jun 24, 2019
@elupanov elupanov deleted the feat/toastr-duplicate-behaviour branch June 24, 2019 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants