fix(context menu): add cursor pointer to menu host #1662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yggg
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1662 +/- ##
==========================================
+ Coverage 83.41% 83.42% +<.01%
==========================================
Files 232 232
Lines 7563 7564 +1
Branches 664 664
==========================================
+ Hits 6309 6310 +1
Misses 1061 1061
Partials 193 193
|
yggg
changed the title
nnixaa
requested changes
Jul 9, 2019
| @@ -6,6 +6,15 @@ | |||
| @import '../../styles/core/mixins'; | |||
|
|
|||
| @mixin nb-context-menu-theme() { | |||
|
|
|||
| .context-menu-host { | |||
There was a problem hiding this comment.
why don't we just put these styles to .component.scss to :host {} ?
nnixaa
approved these changes
Jul 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Fixes #1369