Feature/acl #187
Merged
Feature/acl #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KostyaDanovsky
requested changes
Feb 12, 2018
| imports: [ | ||
| // ... | ||
|
|
||
| NbSecurityModule.forRoot({ |
| ], | ||
| ``` | ||
| That's easy we have just provided a role, so that Nebular can determine which user is currently accessing the app. | ||
| The good thing about this configuration is that it's not tightly coupled with the rest of your authentication flow, which gives you a lof of flexibility over it. |
| } | ||
| ``` | ||
|
|
||
| So we subscribe to the `tokenChange` observable, which will produce a new token each time authentication change occurres. Then we simply get a tole from a token or return default `guest` value. |
| ## Usage | ||
|
|
||
| Finally, we can move on to the part where we start using the ACL. Let's assume that we have that `Post Comment` button, that should only be shown to authenticated users (with a role `user`). | ||
| So we need to hide the button for guests. In your `comment-form.component.ts`, import the `NbAuthorizationChecker` service. |
There was a problem hiding this comment.
I don't really like that name NbAuthorizationChecker
Probably, NbAuthControl will be better
| }) | ||
| export class CommentFormComponent { | ||
|
|
||
| constructor(public authorizationChecker: NbAuthorizationChecker) { } |
There was a problem hiding this comment.
too long name, as minimum we could make it shorter to authChecker
| * Set/Reset ACL service state | ||
| * @param {NbAclState} state | ||
| */ | ||
| setState(state: NbAclState) { |
KostyaDanovsky
requested changes
Feb 13, 2018
| import { Directive, Input, OnDestroy, TemplateRef, ViewContainerRef } from '@angular/core'; | ||
| import { takeWhile } from 'rxjs/operators/takeWhile'; | ||
|
|
||
| import { NbAccessChecker } from '../services/authorization-checker.service'; |
| if (parentRole) { | ||
| parentCan = this.can(this.getRoleParent(role), permission, resource); | ||
| } | ||
| return parentCan ? parentCan : this.exactCan(role, permission, resource); |
There was a problem hiding this comment.
You could write it as return parentCan && this.exactCan(role, permission, resource);
| parentCan = this.can(this.getRoleParent(role), permission, resource); | ||
| } | ||
| return parentCan ? parentCan : this.exactCan(role, permission, resource); | ||
| const parentCan = parentRole && this.can(this.getRoleParent(role), permission, resource); |
There was a problem hiding this comment.
You could use parentRole again here:
const parentCan = parentRole && this.can(parentRole, permission, resource);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves: