-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(select): mark touched on hide trigger only when select is open #1878
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1878 +/- ##
==========================================
+ Coverage 84.02% 84.14% +0.12%
==========================================
Files 234 234
Lines 7695 7703 +8
Branches 675 675
==========================================
+ Hits 6466 6482 +16
+ Misses 1031 1023 -8
Partials 198 198
|
Hi yggg, I have used nb-select with *ngif validation with reactive form, now click anywhere on the page , the validation error appear.
|
Hi @mayanksudden. Please, post an issue with a reproducible example to illustrate the problem (Nebular stackblitz template). As I can see, select calls touched callback once it looses focus, so validation should occur. Also, please specify Nebular version you use. |
I face the same issue presented here in this stackblitz's example
What do I need to update in the project? My package.json
|
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Closes #1418 and #1629.
Prevents select from being marked touched when it's closed and
hide$
trigger emit because user clicks outside select + tests.Also has a fix to mark touched when user tabbed out from select overlay.