-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(calendar): Eva 1.3 #2120
Merged
Merged
feat(calendar): Eva 1.3 #2120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2120 +/- ##
=========================================
- Coverage 84.71% 84.62% -0.1%
=========================================
Files 234 237 +3
Lines 8030 8209 +179
Branches 707 738 +31
=========================================
+ Hits 6803 6947 +144
- Misses 1010 1045 +35
Partials 217 217
|
Tibing
requested changes
Dec 9, 2019
...ents/calendar-kit/components/calendar-navigation/calendar-pageable-navigation.component.scss
Outdated
Show resolved
Hide resolved
...onents/calendar-kit/components/calendar-day-picker/_calendar-day-picker.component.theme.scss
Outdated
Show resolved
Hide resolved
.../theme/components/calendar-kit/components/calendar-day-picker/calendar-day-cell.component.ts
Show resolved
Hide resolved
.../theme/components/calendar-kit/components/calendar-day-picker/calendar-day-cell.component.ts
Show resolved
Hide resolved
...e/components/calendar-kit/components/calendar-day-picker/calendar-day-cell.component.spec.ts
Show resolved
Hide resolved
src/framework/theme/components/calendar/base-calendar.component.ts
Outdated
Show resolved
Hide resolved
src/framework/theme/components/calendar/calendar-range-cells.ts
Outdated
Show resolved
Hide resolved
View mode component was moved outside of pageable component
Co-Authored-By: Nikita Poltoratsky <n.poltoratsky@akveo.com>
Also extracts cells theming into own file.
Tibing
approved these changes
Dec 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Breaking Changes:
NbCalendarHeaderComponent
removed. Along with thatshowHeader
property removed from following components:NbBaseCalendarComponent
NbCalendarRangeComponent
NbCalendarComponent
NbBasePicker
NbBasePickerComponent
medium
andsize-medium
css classes were removed along withmedium
/isMedium
properties from the following classes:NbCalendarDayPickerComponent
NbCalendarMonthPickerComponent
NbCalendarYearPickerComponent
NbBaseCalendarComponent
NbCalendarWeekNumberComponent
Properties
date
,changeMode
,isRtl
removed fromNbCalendarPageableNavigationComponent
File
nb-calendar-week-number.component
renamed tocalendar-week-number.component
YEARS_IN_VIEW, YEARS_IN_ROW
constants removed. UseNbCalendarYearModelService
sgetYearsInView
andgetRowInView
methods.NbCalendarNavigationComponent
replaced withNbCalendarViewModeComponent
.initYears
method removed fromNbCalendarYearPickerComponent
.calendar-range-cells.ts
file split intocalendar-range-day-cell.component.ts
,calendar-range-month-cell.component.ts
andcalendar-range-year-cell.component.ts
.Following theme properties were removed:
calendar-body-height
calendar-header-text-color
calendar-header-text-font-family
calendar-header-title-text-font-size
calendar-header-title-text-font-weight
calendar-header-title-text-line-height
calendar-header-sub-title-text-font-size
calendar-header-sub-title-text-font-weight
calendar-header-sub-title-text-line-height
calendar-navigation-button-width
calendar-large-body-height
calendar-cell-in-range-background-color
calendar-cell-disabled-background-color
datepicker-text-color
datepicker-arrow-size