Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use basic as default status #2136

Merged
merged 5 commits into from
Dec 19, 2019
Merged

refactor: use basic as default status #2136

merged 5 commits into from
Dec 19, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Dec 19, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

BREAKING CHANGE:
Badge, button, progress bar, toastr components now use basic status as a default.

@yggg yggg changed the title Refactor/make basic default status refactor: use basic as default status Dec 19, 2019
@codecov
Copy link

codecov bot commented Dec 19, 2019

Codecov Report

Merging #2136 into master will decrease coverage by 0.02%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master    #2136      +/-   ##
==========================================
- Coverage    84.7%   84.67%   -0.03%     
==========================================
  Files         243      243              
  Lines        8471     8478       +7     
  Branches      758      759       +1     
==========================================
+ Hits         7175     7179       +4     
- Misses       1074     1076       +2     
- Partials      222      223       +1
Impacted Files Coverage Δ
...ramework/theme/components/toastr/toastr.service.ts 97.56% <ø> (ø) ⬆️
src/framework/theme/components/helpers.ts 75% <ø> (ø) ⬆️
.../framework/theme/components/user/user.component.ts 100% <100%> (ø) ⬆️
...mework/theme/components/tabset/tabset.component.ts 92.15% <100%> (ø) ⬆️
...work/theme/components/actions/actions.component.ts 100% <100%> (ø) ⬆️
.../components/progress-bar/progress-bar.component.ts 100% <100%> (ø) ⬆️
...mework/theme/components/button/button.component.ts 87.77% <100%> (ø) ⬆️
...ramework/theme/components/badge/badge.component.ts 93.02% <62.5%> (-6.98%) ⬇️
...framework/theme/components/toastr/toastr-config.ts 84.61% <66.66%> (ø) ⬆️

@yggg yggg merged commit cc9b47e into akveo:master Dec 19, 2019
@yggg yggg deleted the refactor/make-basic-default-status branch December 19, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant