Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(select, autocomplete): add input to set options list class #2560

Merged
merged 9 commits into from
Dec 18, 2020

Conversation

sashaqred
Copy link
Member

@sashaqred sashaqred commented Oct 19, 2020

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Add input for setting overlay class in select
Closes #2314

@sashaqred sashaqred requested a review from yggg October 19, 2020 14:10
@sashaqred sashaqred self-assigned this Oct 19, 2020
@ghost
Copy link

ghost commented Oct 21, 2020

DeepCode's analysis on #45b86c found:

  • ℹ️ 1 minor issue. 👇

Top issues

Description Example fixes
asterisks in jsdoc must be aligned Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #2560 (4ea27e5) into master (09a7ba1) will increase coverage by 0.14%.
The diff coverage is 72.72%.

@@            Coverage Diff             @@
##           master    #2560      +/-   ##
==========================================
+ Coverage   78.95%   79.09%   +0.14%     
==========================================
  Files         253      258       +5     
  Lines        7815     7963     +148     
  Branches      857      872      +15     
==========================================
+ Hits         6170     6298     +128     
- Misses       1382     1391       +9     
- Partials      263      274      +11     
Impacted Files Coverage Δ
.../components/autocomplete/autocomplete.component.ts 91.66% <ø> (ø)
...ork/theme/components/cdk/overlay/overlay.module.ts 100.00% <ø> (ø)
...heme/components/datepicker/datepicker.directive.ts 76.10% <ø> (ø)
.../theme/components/form-field/form-field-control.ts 66.66% <ø> (ø)
src/framework/theme/components/helpers.ts 71.42% <ø> (+4.76%) ⬆️
...work/theme/components/popover/popover.directive.ts 100.00% <ø> (+6.12%) ⬆️
...work/theme/components/spinner/spinner.directive.ts 20.00% <0.00%> (ø)
...work/theme/components/tooltip/tooltip.directive.ts 100.00% <ø> (+5.66%) ⬆️
src/framework/theme/theme.module.ts 63.63% <ø> (ø)
.../framework/theme/components/chat/chat.component.ts 40.00% <16.66%> (+0.71%) ⬆️
... and 44 more

yggg
yggg previously approved these changes Oct 23, 2020
@yggg yggg changed the title feat: add input for setting overlay class in select feat(select, autocomplete): add input to set options list class Dec 18, 2020
@yggg yggg merged commit 92083e8 into master Dec 18, 2020
@yggg yggg deleted the feat/add-input-for-setting-overlay-class-in-select branch December 18, 2020 11:54
yggg pushed a commit that referenced this pull request Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to add class to NbOptionList overlay for NbSelect
2 participants