Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tabset): add a tabId data attribute to the tab button #2738

Merged
merged 5 commits into from
Jun 16, 2021
Merged

feat(tabset): add a tabId data attribute to the tab button #2738

merged 5 commits into from
Jun 16, 2021

Conversation

andreipadolin
Copy link
Contributor

added tab unique id Fixes #2727

@andreipadolin andreipadolin requested a review from yggg May 14, 2021 09:06
@yggg yggg changed the title fix(TabComponent): added tabid attribute fix(tabset): add a tabId data attribute to tab button May 26, 2021
@yggg yggg changed the title fix(tabset): add a tabId data attribute to tab button fix(tabset): add a tabId data attribute to the tab button May 26, 2021
@yggg yggg changed the title fix(tabset): add a tabId data attribute to the tab button feat(tabset): add a tabId data attribute to the tab button May 26, 2021
@andreipadolin andreipadolin requested a review from yggg May 27, 2021 09:17
@yggg yggg merged commit 5aaab17 into akveo:master Jun 16, 2021
@andreipadolin andreipadolin deleted the bugfix-2727 branch June 16, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input tabId of NbTabComponent is ignored
2 participants