Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(range-picker): correct type for min, max, filter properties #2877

Merged

Conversation

katebatura
Copy link
Contributor

@katebatura katebatura commented Sep 16, 2021

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #2700

BREAKING CHANGE:
NbRangepickerComponent's min, max properties are expecting Date (or moment if using moment adapter) type. filter function parameter also corrected to Date. NbDatepicker now a has second generic D to use for min, max, and filter arguments. It should be set to Date or moment type.

@yggg yggg added this to the 9.0.0 milestone Sep 16, 2021
@katebatura katebatura changed the title Fix/2700 nb rangepicker max property type fix(datepicker) add second generic type variable Sep 17, 2021
@yggg yggg changed the title fix(datepicker) add second generic type variable fix(datepicker): add second generic type variable Nov 15, 2021
@yggg yggg changed the title fix(datepicker): add second generic type variable fix(range-picker): correct type for min, max and filter properties Nov 15, 2021
@yggg yggg changed the title fix(range-picker): correct type for min, max and filter properties fix(range-picker): correct type for min, max, filter properties Nov 15, 2021
@yggg yggg merged commit 73cdec0 into akveo:master Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type 'Date' is not assignable to type 'NbCalendarRange<any>'
2 participants