Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(context menu): prevent close on expand icon click #2923

Merged
merged 6 commits into from Nov 26, 2021
Merged

fix(context menu): prevent close on expand icon click #2923

merged 6 commits into from Nov 26, 2021

Conversation

katebatura
Copy link
Contributor

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #2713

Add css property pointer-events: none; to the svg in nb-icon with chevron-icon.

@katebatura katebatura requested a review from yggg November 1, 2021 12:09
@katebatura katebatura self-assigned this Nov 1, 2021
@yggg yggg added this to the 9.0.0 milestone Nov 12, 2021
@yggg yggg changed the title fix(context-menu): prevent closing when chevron-icon is clicked fix(context menu): prevent closing when chevron-icon is clicked Nov 24, 2021
@yggg yggg changed the title fix(context menu): prevent closing when chevron-icon is clicked fix(context menu): prevent closing on expand icon click Nov 24, 2021
yggg
yggg suggested changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@yggg yggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Menu item with children also has .menu-title, .menu-icon and badge elements. Please, ensure clicking on it doesn't trigger close as well.

src/framework/theme/components/context-menu/_context-menu.component.theme.scss Outdated Show resolved Hide resolved
@katebatura katebatura requested a review from yggg November 26, 2021 12:20
@yggg yggg changed the title fix(context menu): prevent closing on expand icon click fix(context menu): prevent close on expand icon click Nov 26, 2021
@yggg yggg merged commit 2b7f60c into akveo:master Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yggg yggg yggg approved these changes

Assignees

@katebatura katebatura

Labels
None yet
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

nb-menu is closed when user clicks on 'chevron' icon to expand children
2 participants
@katebatura @yggg