fix(infinite list): add throttling to scroll listener #2948

evtkhvch · 2021-11-18T14:30:35Z

Please read and mark the following check list before creating a pull request:

I read and followed the CONTRIBUTING.md guide.
I read and followed the New Feature Checklist guide.

Short description of what this resolves:

Closes #2936

Changes

add throttleTime property which ignores subsequent source values for specified duration after scroll emits first value

BREAKING CHANGE:
NbScrollableContainerDimentions class renamed to NbScrollableContainerDimensions.

- fix emit issue when scroll is not triggered - add throttle to onScroll listener - fix typo issues

This reverts commit 5005802.

src/framework/theme/components/list/infinite-list.directive.ts

…indow scroll

evtkhvch added 5 commits November 18, 2021 17:26

fix(infinity-list): emit issues

b800865

- fix emit issue when scroll is not triggered - add throttle to onScroll listener - fix typo issues

fix(layout): layout emit before scroll

5005802

fix(infinite-list): remove getContainerDimensions params

563980a

Revert "fix(layout): layout emit before scroll"

70ffe54

This reverts commit 5005802.

fix(infinite-list): add throttle to tick

fff69c6

evtkhvch marked this pull request as ready for review November 22, 2021 12:00

evtkhvch changed the title ~~fix(infinity-list): scroll listener issue~~ fix(infinity-list): add throttling to scroll listener Nov 22, 2021

fix(infinite-list): remove extra import

80e1aab

evtkhvch requested a review from yggg November 22, 2021 12:03

yggg changed the title ~~fix(infinity-list): add throttling to scroll listener~~ fix(infinite list): add throttling to scroll listener Nov 22, 2021

yggg added this to the 9.0.0 milestone Nov 22, 2021

evtkhvch and others added 9 commits November 24, 2021 15:40

fix(infinite-list): add throttleTime property

40a0e20

fix(infinite-list): add default throttling

69f8ca3

Merge branch 'master' into fix-infinity-list-emit-issues

1637179

refactor(infinite list): remove throttling by default

f3131c8

Merge branch 'master' into fix-infinity-list-emit-issues

4556f3d

fix(infinite-list): move throttle to getContainerDimensions

14d2642

fix(infinite-list): change docs for throttleTime

5ed5f55

fix(infinite-list): element scroll throttling

4562ec9

feat(infinite-list): add throttleTime specs

4817863

yggg suggested changes Nov 26, 2021

View reviewed changes

src/framework/theme/components/list/infinite-list.directive.ts Outdated Show resolved Hide resolved

evtkhvch and others added 8 commits November 30, 2021 19:03

fix(infinite-list): change throttle specs

a926c3b

style(infinite-list): remove extra import

4651954

Merge branch 'master' into fix-infinity-list-emit-issues

839d3ff

test(infinite list): remove redundant variable

723061a

style(test): fix type

76a4e5c

refactor(infinite list): emit window scroll only when we listen for w…

1348edf

…indow scroll

test(infinite list): move first cd run into fakeAsync

75abd7e

Merge branch 'master' into fix-infinity-list-emit-issues

e9ad0a3

yggg approved these changes Dec 1, 2021

View reviewed changes

yggg merged commit 718dd0a into akveo:master Dec 1, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(infinite list): add throttling to scroll listener #2948

fix(infinite list): add throttling to scroll listener #2948

evtkhvch commented Nov 18, 2021 •

edited by yggg

fix(infinite list): add throttling to scroll listener #2948

fix(infinite list): add throttling to scroll listener #2948

Conversation

evtkhvch commented Nov 18, 2021 • edited by yggg

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

evtkhvch commented Nov 18, 2021 •

edited by yggg