Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scroll service): listen position requests right after layout created #2949

Merged
merged 4 commits into from Nov 22, 2021

Conversation

evtkhvch
Copy link
Contributor

@evtkhvch evtkhvch commented Nov 19, 2021

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #2832

Prevent NbLayoutScrollService.onGetPosition emit before NbLayoutComponent is subscribed

@evtkhvch evtkhvch changed the title fix(layout): layout emit before scroll fix(layout): scroll emit before layout is initialized Nov 19, 2021
@evtkhvch evtkhvch requested a review from yggg November 19, 2021 15:17
@evtkhvch evtkhvch changed the title fix(layout): scroll emit before layout is initialized fix(layout): scroll position emit value before layout is subscribed Nov 19, 2021
@evtkhvch evtkhvch changed the title fix(layout): scroll position emit value before layout is subscribed fix(layout): scroll position emits value before layout is subscribed Nov 19, 2021
@yggg yggg changed the title fix(layout): scroll position emits value before layout is subscribed fix(scroll service): listen position requests right after layout created Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentattion - Live View / Examples Not Always Loading
2 participants