Remove @akveo/ng2-completer and ng2-completer #5896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 13, 2021
|
Note: In Order to get (=> i let the package-lock.json untouched, so merging the MRs independently should not destroy anything and new users should be able to clone and start the project in every merge state. Only for web-developers who need a fresh package installation this will have an impact) To see all changes of the three MRs together, see comparison in my fork: MaaxGr/ngx-admin@cabe4bd...910b4c4 |
ugurkoysuren
previously approved these changes
May 12, 2022
vaibhavkumar-sf
previously approved these changes
May 16, 2022
|
It must be merged asap, |
elupanov
previously approved these changes
May 20, 2022
elupanov
dismissed stale reviews from vaibhavkumar-sf, ugurkoysuren, and themself
via
4a28d06
|
🤟 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request (check one with "x"):
Short description of what this resolves:
Fixes #5814. smart-table dependency did change in version 1.7.0, see https://github.com/akveo/ng2-smart-table/blob/master/CHANGELOG.md
(I recreated the MR because i pushed the package-lock.json inadvertently)