New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add topInsetEnabled prop when StatusBar is translucent #1372

Merged

malashkevich merged 22 commits into akveo:master from whitestranger7:update/modalService

Mar 18, 2021

Contributor

whitestranger7 commented Mar 11, 2021

Please read and mark the following check list before creating a pull request:

I read and followed the CONTRIBUTING.md guide.
I read and followed the New Feature Checklist guide.

Short description of what this resolves:

Related to #743

Ivan Vezhnavets and others added 5 commits

February 7, 2021 20:12


          fix: add change orientation event with modal render

b5c2eee


          update: change forceRender method, make it private

2ac98ef


          update: rename method regarding event listener meaning

dfb762d


          Merge branch 'master' into update/modal


          feat: add topInsetEnabled prop when StatusBar is translucent

020c842

whitestranger7 marked this pull request as draft

March 11, 2021 14:57

whitestranger7 marked this pull request as ready for review

March 11, 2021 15:05

malashkevich reviewed

View reviewed changes

src/components/devsupport/components/measure/measure.component.tsx Outdated Show resolved Hide resolved

malashkevich reviewed

View reviewed changes

src/components/devsupport/components/measure/measure.component.tsx Outdated Show resolved Hide resolved

malashkevich reviewed

View reviewed changes

src/components/theme/application/applicationProvider.component.tsx Outdated Show resolved Hide resolved

malashkevich requested changes

View reviewed changes

Member

malashkevich left a comment

Please fix the issues,
and also do not forget about tests

Ivan Vezhnavets added 2 commits

March 14, 2021 17:11


          update(measure component): rollback changes

a8e168d


          update(modalServie): add method for statusbar config height

c2c2a07

artyorsh previously requested changes

View reviewed changes

src/components/theme/modal/modal.service.tsx Outdated Show resolved Hide resolved

src/components/theme/modal/modal.service.tsx Outdated Show resolved Hide resolved

malashkevich reviewed

View reviewed changes

src/components/theme/application/applicationProvider.component.tsx Outdated Show resolved Hide resolved

malashkevich reviewed

View reviewed changes

src/components/theme/modal/modal.service.tsx Outdated Show resolved Hide resolved

malashkevich reviewed

View reviewed changes

src/components/devsupport/components/measure/measure.component.tsx Outdated Show resolved Hide resolved

malashkevich requested changes

View reviewed changes

Member

malashkevich left a comment

need changes


          fix(modalService): fix accordingly comments

a78f4b5

whitestranger7 requested a review from malashkevich

March 15, 2021 10:22

malashkevich reviewed

View reviewed changes

src/components/devsupport/components/measure/measure.component.tsx Outdated Show resolved Hide resolved

malashkevich reviewed

View reviewed changes

src/components/devsupport/components/measure/measure.component.tsx Outdated Show resolved Hide resolved

malashkevich reviewed

View reviewed changes

src/components/theme/application/applicationProvider.component.tsx Show resolved Hide resolved

malashkevich reviewed

View reviewed changes

src/components/ui/menu/menuGroup.component.tsx Outdated Show resolved Hide resolved

malashkevich reviewed

View reviewed changes

src/components/ui/modal/modal.component.tsx Outdated Show resolved Hide resolved

malashkevich reviewed

View reviewed changes

src/components/ui/popover/popover.component.tsx Outdated Show resolved Hide resolved


          fix: resolve comments

ddd5742

whitestranger7 requested a review from malashkevich

March 16, 2021 14:57

artyorsh reviewed

View reviewed changes

src/components/devsupport/components/measure/measure.component.tsx Outdated Show resolved Hide resolved

src/components/ui/menu/menuGroup.component.tsx Show resolved Hide resolved


          updaet(measureElement): make props optional, add default prop value

6c0cb8e


          fix: update default props types realisation

b7c6ac8

malashkevich reviewed

View reviewed changes

src/components/theme/modal/modal.service.tsx Outdated Show resolved Hide resolved

malashkevich reviewed

View reviewed changes

src/components/theme/modal/modal.service.tsx Outdated Show resolved Hide resolved

Member

malashkevich commented Mar 18, 2021

@whitestranger7 add access modifiers and resolve conflict

Ivan Vezhnavets added 11 commits

March 18, 2021 12:44


          feat(modalService): add access modifiers

d360a18


          feat: add topInsetEnabled prop when StatusBar is translucent

56b5c2b


          update(measure component): rollback changes

fb628da


          update(modalServie): add method for statusbar config height

0d63474


          fix(modalService): fix accordingly comments

e773075


          fix: resolve comments

94725f3


          updaet(measureElement): make props optional, add default prop value

3e71020


          fix: update default props types realisation

0634a89


          feat(modalService): add access modifiers

2f67d20


          Merge branch 'update/modalService' of https://github.com/whitestrange…

c68a526

…r7/react-native-ui-kitten into update/modalService


          merge: master merge & resolve conflicts

d3401e0

whitestranger7 requested a review from malashkevich

March 18, 2021 11:15

malashkevich requested a review from artyorsh

March 18, 2021 14:54

malashkevich approved these changes

View reviewed changes

malashkevich approved these changes

View reviewed changes

malashkevich dismissed artyorsh’s stale review

March 18, 2021 14:55

stale

malashkevich merged commit 407356e into akveo:master

johnkmzhou mentioned this pull request

Popover style prop #1465

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment