Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): add custom warnings for incorrect component usage #471

Merged
merged 1 commit into from Jun 21, 2019
Merged

feat(ui): add custom warnings for incorrect component usage #471

merged 1 commit into from Jun 21, 2019

Conversation

artyorsh
Copy link
Collaborator

@artyorsh artyorsh commented Jun 21, 2019 •
edited

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Adds custom console warnings for incorrect component usage

This will also make components to apply default styles in case incorrect where provided

image

Closes #469

@artyorsh artyorsh added enhancement 📱 Components components module-specific labels Jun 21, 2019
@artyorsh artyorsh requested a review from 32penkin June 21, 2019 12:40
@artyorsh artyorsh self-assigned this Jun 21, 2019
@artyorsh artyorsh merged commit 981d5c8 into master Jun 21, 2019
@artyorsh artyorsh deleted the feat/style-error-handle branch June 21, 2019 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malashkevich malashkevich malashkevich approved these changes

@32penkin 32penkin 32penkin approved these changes

Assignees

@artyorsh artyorsh

Labels
📱 Components components module-specific
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

undefined is not an object (evaluating 'this.meta.appearances')
3 participants
@artyorsh @malashkevich @32penkin