Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(template): update template modules to new cli config #623

Merged
merged 5 commits into from
Sep 23, 2019
Merged

refactor(template): update template modules to new cli config #623

merged 5 commits into from
Sep 23, 2019

Conversation

artyorsh
Copy link
Collaborator

@artyorsh artyorsh commented Sep 19, 2019 •
edited
Loading

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

  • Update template modules to fit new react-native-cli config

Closes #618

@artyorsh artyorsh added the Template specific for template projects label Sep 19, 2019
@artyorsh artyorsh self-assigned this Sep 19, 2019
32penkin
32penkin previously approved these changes Sep 19, 2019
View reviewed changes
Copy link
Member

@32penkin 32penkin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to investigate reducing native sources. Seems to be possible.

This was referenced Sep 21, 2019
Closed
Closed
@artyorsh artyorsh merged commit 3bc19af into master Sep 23, 2019
@artyorsh artyorsh deleted the refactor/template-update-to-new-config branch September 23, 2019 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@32penkin 32penkin 32penkin approved these changes

Assignees

@artyorsh artyorsh

Labels
Template specific for template projects
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

install.js does not exist in react-native-template-ui-kitten-typescript
2 participants
@artyorsh @32penkin